[worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope.

[worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope.

BUG=567358
Committed: https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80
Cr-Commit-Position: refs/heads/master@{#410812}

[ikilpatrick, 2016-08-06 22:14:15]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 22:14:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 22:41:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 22:41:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[ikilpatrick, 2016-08-07 01:25:20]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 01:25:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-07 02:36:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-07 02:36:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ikilpatrick, 2016-08-08 13:20:49]

The CQ bit was checked by ikilpatrick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 13:20:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-08-08 14:07:30]

ikilpatrick@chromium.org changed reviewers:
+ dgozman@chromium.org, nhiroki@chromium.org, yhirano@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:40:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 14:40:47]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-08-08 15:38:32]

lgtm

[nhiroki, 2016-08-08 15:42:47]

lgtm

[ikilpatrick, 2016-08-08 16:42:02]

ikilpatrick@chromium.org changed reviewers:
+ flackr@chromium.org, majidvp@chromium.org

[ikilpatrick, 2016-08-08 16:42:02]

+majidvp/flackr for compositorworker/

[yhirano, 2016-08-09 06:33:06]

lgtm

https://codereview.chromium.org/2220213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right):

https://codereview.chromium.org/2220213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerThread.cpp:568: if
(m_consoleMessageStorage)
Why don't you clear the pointer unconditionally?

[flackr, 2016-08-09 11:45:38]

lgtm

[majidvp, 2016-08-09 13:35:17]

On 2016/08/09 11:45:38, flackr wrote:
> lgtm

compositorworker lgtm

[ikilpatrick, 2016-08-09 14:13:58]

Thanks all!

https://codereview.chromium.org/2220213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/workers/WorkerThread.cpp (right):

https://codereview.chromium.org/2220213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/workers/WorkerThread.cpp:568: if
(m_consoleMessageStorage)
On 2016/08/09 06:33:06, yhirano wrote:
> Why don't you clear the pointer unconditionally?

Done.

[ikilpatrick, 2016-08-09 14:14:10]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-08-09 14:14:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, nhiroki@chromium.org, flackr@chromium.org,
majidvp@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2220213002/#ps80001
(title: "address comments.")

[commit-bot: I haz the power, 2016-08-09 14:14:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 14:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 14:19:45]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-08-09 15:44:24]

owner LGTM

[ikilpatrick, 2016-08-09 17:42:49]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2016-08-09 17:43:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 20:52:57]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-09 20:55:01]

Description was changed from

==========
[worklets] Move ConsoleMessageStorage to WorkerThread instead of
WorkerGlobalScope.

BUG=567358
==========

to

==========
[worklets] Move ConsoleMessageStorage to WorkerThread instead of
WorkerGlobalScope.

BUG=567358

Committed: https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80
Cr-Commit-Position: refs/heads/master@{#410812}
==========

[commit-bot: I haz the power, 2016-08-09 20:55:02]

Patchset 5 (id:??) landed as
https://crrev.com/c5bdd71fddc3d7eb58c6a9f403cc755a15e37f80
Cr-Commit-Position: refs/heads/master@{#410812}