third_party/WebKit/Source/core/workers/WorkerThread.h - Issue 2220213002: [worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThread.h

Issue 2220213002: [worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerThread.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerThread.h b/third_party/WebKit/Source/core/workers/WorkerThread.h

index ffdf714a290a674d479fbd2934268c9d1eebd683..834fda0c02a1151fde140019074fae7add1ffb73 100644

--- a/third_party/WebKit/Source/core/workers/WorkerThread.h

+++ b/third_party/WebKit/Source/core/workers/WorkerThread.h

@@ -109,7 +109,7 @@ public:

static void terminateAndWaitForAllWorkers();

virtual WorkerBackingThread& workerBackingThread() = 0;

- virtual ConsoleMessageStorage* consoleMessageStorage() = 0;

+ ConsoleMessageStorage* consoleMessageStorage() const { return m_consoleMessageStorage.get(); }

virtual bool shouldAttachThreadDebugger() const { return true; }

v8::Isolate* isolate();

@@ -238,6 +238,7 @@ private:

// |m_runningDebuggerTask|, |m_exitCode| and |m_microtaskRunner|.

Mutex m_threadStateMutex;

+ Persistent<ConsoleMessageStorage> m_consoleMessageStorage;

Persistent<WorkerOrWorkletGlobalScope> m_globalScope;

Persistent<WorkerInspectorController> m_workerInspectorController;