third_party/WebKit/Source/core/workers/WorkerGlobalScope.h - Issue 2220213002: [worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

Issue 2220213002: [worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

index 22934d738e81c456c6d14ee9e2495e03a6392e2f..1c7cdd4cb44a88460e91bbd34c043b03e3df852c 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h

@@ -128,7 +128,6 @@ public:

WorkerOrWorkletScriptController* scriptController() final { return m_scriptController.get(); }

WorkerClients* clients() { return m_workerClients.get(); }

- ConsoleMessageStorage* consoleMessageStorage() { return m_consoleMessageStorage.get(); }

DECLARE_VIRTUAL_TRACE();

@@ -175,8 +174,6 @@ private:

const double m_timeOrigin;

- Member<ConsoleMessageStorage> m_consoleMessageStorage;

HeapListHashSet<Member<V8AbstractEventListener>> m_eventListeners;

HeapHashMap<int, Member<ErrorEvent>> m_pendingErrorEvents;