third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp - Issue 2220213002: [worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2220213002: [worklets] Move ConsoleMessageStorage to WorkerThread instead of WorkerGlobalScope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerGlobalScope.h ('k') | third_party/WebKit/Source/core/workers/WorkerThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

index a272b97ca5d733f4a26080fcb040889ba7001bd2..4d5192dabb97c756d37fedda027bdfc2185acf18 100644

--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

@@ -259,7 +259,7 @@ void WorkerGlobalScope::addConsoleMessage(ConsoleMessage* consoleMessage)

{

DCHECK(isContextThread());

thread()->workerReportingProxy().reportConsoleMessage(consoleMessage->source(), consoleMessage->level(), consoleMessage->message(), consoleMessage->location());

- m_consoleMessageStorage->addConsoleMessage(this, consoleMessage);

+ thread()->consoleMessageStorage()->addConsoleMessage(this, consoleMessage);

}

WorkerEventQueue* WorkerGlobalScope::getEventQueue() const

@@ -297,7 +297,6 @@ WorkerGlobalScope::WorkerGlobalScope(const KURL& url, const String& userAgent, W

, m_workerClients(workerClients)

, m_timers(Platform::current()->currentThread()->scheduler()->timerTaskRunner()->clone())

, m_timeOrigin(timeOrigin)

- , m_consoleMessageStorage(new ConsoleMessageStorage())

, m_lastPendingErrorEventId(0)

{

setSecurityOrigin(SecurityOrigin::create(url));

@@ -349,7 +348,6 @@ DEFINE_TRACE(WorkerGlobalScope)

visitor->trace(m_eventQueue);

visitor->trace(m_workerClients);

visitor->trace(m_timers);

- visitor->trace(m_consoleMessageStorage);

visitor->trace(m_eventListeners);

visitor->trace(m_pendingErrorEvents);

ExecutionContext::trace(visitor);