Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Side by Side Diff: infra/bots/recipe_modules/vars/api.py

Issue 2217523002: [recipes] Fixes for Coverage bot (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_sub2
Patch Set: Fix compile env Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # pylint: disable=W0201 6 # pylint: disable=W0201
7 7
8 8
9 from recipe_engine import recipe_api 9 from recipe_engine import recipe_api
10 import os 10 import os
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 # Vulkan. 144 # Vulkan.
145 if builder_dict.get('extra_config') == 'Vulkan': 145 if builder_dict.get('extra_config') == 'Vulkan':
146 gyp_defs['skia_vulkan'] = '1' 146 gyp_defs['skia_vulkan'] = '1'
147 gyp_defs['skia_vulkan_debug_layers'] = '0' 147 gyp_defs['skia_vulkan_debug_layers'] = '0'
148 148
149 return gyp_defs 149 return gyp_defs
150 150
151 151
152 def get_extra_env_vars(builder_dict): 152 def get_extra_env_vars(builder_dict):
153 env = {} 153 env = {}
154 if builder_dict.get('configuration') == 'Coverage': 154 if builder_dict.get('compiler') == 'Clang':
155 # We have to use Clang 3.6 because earlier versions do not support the
156 # compile flags we use and 3.7 and 3.8 hit asserts during compilation.
157 env['CC'] = '/usr/bin/clang-3.6'
158 env['CXX'] = '/usr/bin/clang++-3.6'
159 elif builder_dict.get('compiler') == 'Clang':
160 env['CC'] = '/usr/bin/clang' 155 env['CC'] = '/usr/bin/clang'
161 env['CXX'] = '/usr/bin/clang++' 156 env['CXX'] = '/usr/bin/clang++'
162 157
163 # SKNX_NO_SIMD, SK_USE_DISCARDABLE_SCALEDIMAGECACHE, etc. 158 # SKNX_NO_SIMD, SK_USE_DISCARDABLE_SCALEDIMAGECACHE, etc.
164 extra_config = builder_dict.get('extra_config', '') 159 extra_config = builder_dict.get('extra_config', '')
165 if extra_config.startswith('SK') and extra_config.isupper(): 160 if extra_config.startswith('SK') and extra_config.isupper():
166 env['CPPFLAGS'] = '-D' + extra_config # pragma: no cover 161 env['CPPFLAGS'] = '-D' + extra_config # pragma: no cover
167 162
168 return env 163 return env
169 164
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 self.patchset = self.m.properties['patchset'] 801 self.patchset = self.m.properties['patchset']
807 self.rietveld = self.m.properties['rietveld'] 802 self.rietveld = self.m.properties['rietveld']
808 self.upload_dm_results = self.builder_spec['upload_dm_results'] 803 self.upload_dm_results = self.builder_spec['upload_dm_results']
809 self.upload_perf_results = self.builder_spec['upload_perf_results'] 804 self.upload_perf_results = self.builder_spec['upload_perf_results']
810 self.dm_dir = self.m.path.join( 805 self.dm_dir = self.m.path.join(
811 self.swarming_out_dir, 'dm') 806 self.swarming_out_dir, 'dm')
812 self.perf_data_dir = self.m.path.join(self.swarming_out_dir, 807 self.perf_data_dir = self.m.path.join(self.swarming_out_dir,
813 'perfdata', self.builder_name, 'data') 808 'perfdata', self.builder_name, 'data')
814 self.dm_flags = self.builder_spec['dm_flags'] 809 self.dm_flags = self.builder_spec['dm_flags']
815 self.nanobench_flags = self.builder_spec['nanobench_flags'] 810 self.nanobench_flags = self.builder_spec['nanobench_flags']
OLDNEW
« no previous file with comments | « infra/bots/recipe_modules/flavor/coverage_flavor.py ('k') | infra/bots/recipes/swarm_compile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698