Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215403002: [turbofan] Make Float32Neg and Float64Neg mandatory operators. (Closed)

Created:
4 years, 4 months ago by ahaas
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make Float32Neg and Float64Neg mandatory operators. R=bmeurer@chromium.org Committed: https://crrev.com/6c44ab30fd6a74dd4a334b8d9ccc370bc1591d75 Cr-Commit-Position: refs/heads/master@{#38399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -79 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +6 lines, -8 lines 0 comments Download
M src/compiler/machine-operator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +4 lines, -40 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 4 months ago (2016-08-05 14:01:16 UTC) #1
Benedikt Meurer
lgtm
4 years, 4 months ago (2016-08-05 18:47:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215403002/1
4 years, 4 months ago (2016-08-05 18:47:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:49:22 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:52:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6c44ab30fd6a74dd4a334b8d9ccc370bc1591d75
Cr-Commit-Position: refs/heads/master@{#38399}

Powered by Google App Engine
This is Rietveld 408576698