test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc - Issue 2215403002: [turbofan] Make Float32Neg and Float64Neg mandatory operators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

Issue 2215403002: [turbofan] Make Float32Neg and Float64Neg mandatory operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/compiler/arm/instruction-selector-arm-unittest.cc ('k') | test/unittests/compiler/machine-operator-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

diff --git a/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc b/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

index a743d54f35392693262ac2e6fcf5232c14c5d92f..7e0bece3764c527d01db7f3cf0e2dea518eb3969 100644

--- a/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

+++ b/test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc

@@ -4273,7 +4273,7 @@ TEST_F(InstructionSelectorTest, Float32Neg) {

StreamBuilder m(this, MachineType::Float32(), MachineType::Float32());

Node* const p0 = m.Parameter(0);

// Don't use m.Float32Neg() as that generates an explicit sub.

- Node* const n = m.AddNode(m.machine()->Float32Neg().op(), m.Parameter(0));

+ Node* const n = m.AddNode(m.machine()->Float32Neg(), m.Parameter(0));

m.Return(n);

Stream s = m.Build();

ASSERT_EQ(1U, s.size());

@@ -4288,7 +4288,7 @@ TEST_F(InstructionSelectorTest, Float64Neg) {

StreamBuilder m(this, MachineType::Float64(), MachineType::Float64());

Node* const p0 = m.Parameter(0);

// Don't use m.Float64Neg() as that generates an explicit sub.

- Node* const n = m.AddNode(m.machine()->Float64Neg().op(), m.Parameter(0));

+ Node* const n = m.AddNode(m.machine()->Float64Neg(), m.Parameter(0));

m.Return(n);

Stream s = m.Build();

ASSERT_EQ(1U, s.size());