Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2215323004: Mojo C++ bindings: inline Get*DataView() methods. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), Fady Samuel, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@85_6_transform
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: inline Get*DataView() methods. These methods are small getters and should be inlined. It slightly improves the cc_serialization_perftest deserialization about 2~3%. BUG=624459 Committed: https://crrev.com/3d09b9179399c8c0f481494b4c8287bc8c3293b6 Cr-Commit-Position: refs/heads/master@{#410143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
yzshen1
Average numbers from 3 runs of cc_perftests: =========================== ' StructTraits deserialization: num runs in 2 ...
4 years, 4 months ago (2016-08-05 17:28:55 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-05 18:27:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215323004/1
4 years, 4 months ago (2016-08-05 18:28:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 19:34:29 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 19:38:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d09b9179399c8c0f481494b4c8287bc8c3293b6
Cr-Commit-Position: refs/heads/master@{#410143}

Powered by Google App Engine
This is Rietveld 408576698