mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl - Issue 2215323004: Mojo C++ bindings: inline Get*DataView() methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

Issue 2215323004: Mojo C++ bindings: inline Get*DataView() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@85_6_transform

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl ('k') | mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

index 575a331769a8c2078b2490b93b99b9023505d602..4a4948cdbb60ff35f77b8813f16252fd91c60a94 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl

@@ -17,7 +17,7 @@ class {{struct.name}}DataView {

{%- set kind = pf.field.kind %}

{%- set name = pf.field.name %}

{%- if kind|is_union_kind %}

- void Get{{name|under_to_camel}}DataView(

+ inline void Get{{name|under_to_camel}}DataView(

{{kind|cpp_data_view_type}}* output);

bool Read{{name|under_to_camel}}({{kind|cpp_wrapper_type}}* output) {

@@ -32,7 +32,7 @@ class {{struct.name}}DataView {

}

{%- elif kind|is_object_kind %}

- void Get{{name|under_to_camel}}DataView(

+ inline void Get{{name|under_to_camel}}DataView(

{{kind|cpp_data_view_type}}* output);

template <typename UserType>