mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl - Issue 2215323004: Mojo C++ bindings: inline Get*DataView() methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

Issue 2215323004: Mojo C++ bindings: inline Get*DataView() methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@85_6_transform

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

index 1702533907074421631ed1edb2e3e32be99eae81..95311dc124c5f414f55904bff5d952dd4188cade 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_definition.tmpl

@@ -3,7 +3,7 @@

{%- set name = pf.field.name %}

{%- if kind|is_union_kind %}

-void {{struct.name}}DataView::Get{{name|under_to_camel}}DataView(

+inline void {{struct.name}}DataView::Get{{name|under_to_camel}}DataView(

{{kind|cpp_data_view_type}}* output) {

{%- if pf.min_version != 0 %}

auto pointer = data_->header_.version >= {{pf.min_version}}

@@ -15,7 +15,7 @@ void {{struct.name}}DataView::Get{{name|under_to_camel}}DataView(

}

{%- elif kind|is_object_kind %}

-void {{struct.name}}DataView::Get{{name|under_to_camel}}DataView(

+inline void {{struct.name}}DataView::Get{{name|under_to_camel}}DataView(

{{kind|cpp_data_view_type}}* output) {

{%- if pf.min_version != 0 %}

auto pointer = data_->header_.version >= {{pf.min_version}}

« no previous file with comments | « mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl ('k') | no next file » | no next file with comments »