Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2215323003: Start using RenderTargetProxy (omnibus) (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
3 years, 6 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start using RenderTargetProxy (omnibus) Split into: https://codereview.chromium.org/2298253002/ (Add read/write-Pixels to GrDrawContext) https://codereview.chromium.org/2301523003/ (Have GrSurfaceProxys and GrGpuResources draw from the same pool of unique ids) https://codereview.chromium.org/2299523004/ (Flush some non-substantive Ganesh changes) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215323003

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : update #

Patch Set 4 : update #

Patch Set 5 : update to ToT #

Patch Set 6 : git #

Patch Set 7 : git #

Patch Set 8 : update #

Patch Set 9 : update #

Patch Set 10 : update #

Patch Set 11 : git #

Patch Set 12 : git #

Patch Set 13 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -249 lines) Patch
M gm/texturedomaineffect.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkMaskFilter.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M include/gpu/GrPaint.h View 1 2 3 4 5 6 7 2 chunks +10 lines, -0 lines 0 comments Download
M include/gpu/GrRenderTargetContext.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrTextureProvider.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M include/private/GrSurfaceProxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M include/private/GrTextureProxy.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +15 lines, -0 lines 0 comments Download
M src/core/SkBlurImageFilter.cpp View 1 2 3 4 5 6 7 8 9 10 4 chunks +10 lines, -7 lines 0 comments Download
M src/core/SkGpuBlurUtils.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkGpuBlurUtils.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 chunks +37 lines, -34 lines 0 comments Download
M src/core/SkImageCacherator.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +7 lines, -5 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +11 lines, -0 lines 0 comments Download
M src/core/SkSpecialSurface.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -2 lines 0 comments Download
M src/effects/GrAlphaThresholdFragmentProcessor.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -0 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 3 4 5 6 7 8 9 10 6 chunks +10 lines, -8 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 10 chunks +19 lines, -16 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 5 6 7 8 9 4 chunks +8 lines, -6 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +8 lines, -6 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 3 4 5 6 7 9 chunks +25 lines, -12 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 2 3 4 5 6 7 8 9 10 5 chunks +10 lines, -7 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +19 lines, -17 lines 0 comments Download
M src/gpu/GrClipStackClip.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrClipStackClip.cpp View 1 2 3 4 5 6 7 8 9 10 6 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPipeline.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 2 3 4 5 6 7 1 chunk +12 lines, -0 lines 0 comments Download
M src/gpu/GrRenderTargetContext.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +4 lines, -9 lines 0 comments Download
M src/gpu/GrRenderTargetContextPriv.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/GrRenderTargetOpList.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrRenderTargetOpList.cpp View 1 2 3 4 5 6 7 8 9 10 11 9 chunks +24 lines, -15 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/GrTextureToYUVPlanes.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrBatch.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrClearBatch.h View 1 2 3 4 5 6 7 8 9 10 7 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/batches/GrClearStencilClipBatch.h View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/batches/GrCopySurfaceBatch.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDiscardBatch.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/batches/GrDrawBatch.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStencilPathBatch.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +16 lines, -13 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 1 2 2 chunks +35 lines, -0 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +42 lines, -0 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -0 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 1 2 3 4 5 6 7 8 9 10 3 chunks +13 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SRGBMipMapTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +7 lines, -5 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +6 lines, -1 line 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
robertphillips
3 years, 6 months ago (2017-06-01 15:48:01 UTC) #5
Message was sent while issue was closed. 
Closing - this is ancient history

Powered by Google App Engine
This is Rietveld 408576698