First step to remove SingleRequestHostResolver.

First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

Second part - https://codereview.chromium.org/2212873002/

BUG=630301
Committed: https://crrev.com/320d596edc998927c4578323e5c0797963370ae9
Cr-Commit-Position: refs/heads/master@{#411981}

[maksims (do not use this acc), 2016-08-04 11:10:38]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 11:10:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-08-04 11:10:56]

Description was changed from

==========
do not use single

BUG=
==========

to

==========
do not use single

BUG=

chromium-reviews, cbentzel+watch@chromium.org, jam, Randy Smith - OOO until 8-1,
darin-cc@chromium.org, Paweł Hajdan Jr., loading-reviews@chromium.org, mmenke
==========

[commit-bot: I haz the power, 2016-08-04 11:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 11:42:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maksims (do not use this acc), 2016-08-05 06:12:26]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 06:12:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 06:43:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 06:43:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maksims (do not use this acc), 2016-08-05 09:59:42]

Description was changed from

==========
do not use single

BUG=

chromium-reviews, cbentzel+watch@chromium.org, jam, Randy Smith - OOO until 8-1,
darin-cc@chromium.org, Paweł Hajdan Jr., loading-reviews@chromium.org, mmenke
==========

to

==========
Make Callers Use HostResolver Instead of SingleRequestHostResolver.

BUG=

chromium-reviews, cbentzel+watch@chromium.org, jam, Randy Smith - OOO until 8-1,
darin-cc@chromium.org, Paweł Hajdan Jr., loading-reviews@chromium.org, mmenke
==========

[maksims (do not use this acc), 2016-08-05 10:52:25]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 10:52:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 11:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 11:26:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maksims (do not use this acc), 2016-08-08 06:22:54]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 06:23:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 07:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 07:06:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maksims (do not use this acc), 2016-08-08 07:48:28]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 07:48:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 08:22:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 08:22:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[maksims (do not use this acc), 2016-08-08 11:51:52]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 11:51:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maksims (do not use this acc), 2016-08-08 11:52:17]

Patchset #2 (id:20001) has been deleted

[maksims (do not use this acc), 2016-08-08 11:52:25]

Patchset #2 (id:40001) has been deleted

[maksims (do not use this acc), 2016-08-08 11:52:33]

Patchset #2 (id:60001) has been deleted

[maksims (do not use this acc), 2016-08-08 11:52:40]

Patchset #2 (id:80001) has been deleted

[maksims (do not use this acc), 2016-08-08 11:52:52]

Patchset #1 (id:1) has been deleted

[maksims (do not use this acc), 2016-08-08 11:54:51]

Description was changed from

==========
Make Callers Use HostResolver Instead of SingleRequestHostResolver.

BUG=

chromium-reviews, cbentzel+watch@chromium.org, jam, Randy Smith - OOO until 8-1,
darin-cc@chromium.org, Paweł Hajdan Jr., loading-reviews@chromium.org, mmenke
==========

to

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver.

BUG=630301
==========

[maksims (do not use this acc), 2016-08-08 11:54:51]

maksim.sisov@intel.com changed reviewers:
+ mmenke@chromium.org

[maksims (do not use this acc), 2016-08-08 11:55:32]

Description was changed from

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver.

BUG=630301
==========

to

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

BUG=630301
==========

[commit-bot: I haz the power, 2016-08-08 12:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 12:26:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[maksims (do not use this acc), 2016-08-09 09:44:34]

Hi,

I need your help. What is this |liveness_| is about? I cannot see the issue
about that. This liveness_ is a private variable in net_log.cc. 

The unittest that is failing is
PredictorBrowserTest.ShutdownWhenResolutionIsPendingTest

The error is
[28523:28601:0808/051202:FATAL:net_log.cc(515)] Check failed: ALIVE == liveness
(3390155539 vs. 3735928559)

[maksims (do not use this acc), 2016-08-09 09:45:54]

On 2016/08/09 09:44:34, maksims wrote:
> Hi,
> 
> I need your help. What is this |liveness_| is about? I cannot see the issue
> about that. This liveness_ is a private variable in net_log.cc. 
> 
> The unittest that is failing is
> PredictorBrowserTest.ShutdownWhenResolutionIsPendingTest
> 
> The error is
> [28523:28601:0808/051202:FATAL:net_log.cc(515)] Check failed: ALIVE ==
liveness
> (3390155539 vs. 3735928559)

I am talking about this issue - crbug.com/467797 . I cannot see it. Thus, I do
not understand this liveness thing.

[maksims (do not use this acc), 2016-08-09 09:48:16]

Description was changed from

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

BUG=630301
==========

to

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

Second part - https://codereview.chromium.org/2212873002/

BUG=630301
==========

[mmenke, 2016-08-09 17:10:11]

On 2016/08/09 09:45:54, maksims wrote:
> On 2016/08/09 09:44:34, maksims wrote:
> > Hi,
> > 
> > I need your help. What is this |liveness_| is about? I cannot see the issue
> > about that. This liveness_ is a private variable in net_log.cc. 
> > 
> > The unittest that is failing is
> > PredictorBrowserTest.ShutdownWhenResolutionIsPendingTest
> > 
> > The error is
> > [28523:28601:0808/051202:FATAL:net_log.cc(515)] Check failed: ALIVE ==
> liveness
> > (3390155539 vs. 3735928559)
> 
> I am talking about this issue - crbug.com/467797 . I cannot see it. Thus, I do
> not understand this liveness thing.

It means (Or probably means, at least) that the NetLog (ChromeNetLog) is
apparently being destroyed before the IOThread is torn down.  IF that's what's
happening, this is a bug.  Curious that this CL unearthed the issue.

[Randy Smith (Not in Mondays), 2016-08-09 17:33:52]

[+juliatuttle FHI]

[mmenke, 2016-08-09 18:27:57]

On 2016/08/09 17:10:11, mmenke wrote:
> On 2016/08/09 09:45:54, maksims wrote:
> > On 2016/08/09 09:44:34, maksims wrote:
> > > Hi,
> > > 
> > > I need your help. What is this |liveness_| is about? I cannot see the
issue
> > > about that. This liveness_ is a private variable in net_log.cc. 
> > > 
> > > The unittest that is failing is
> > > PredictorBrowserTest.ShutdownWhenResolutionIsPendingTest
> > > 
> > > The error is
> > > [28523:28601:0808/051202:FATAL:net_log.cc(515)] Check failed: ALIVE ==
> > liveness
> > > (3390155539 vs. 3735928559)
> > 
> > I am talking about this issue - crbug.com/467797 . I cannot see it. Thus, I
do
> > not understand this liveness thing.
> 
> It means (Or probably means, at least) that the NetLog (ChromeNetLog) is
> apparently being destroyed before the IOThread is torn down.  IF that's what's
> happening, this is a bug.  Curious that this CL unearthed the issue.

Actually, it's no the NetLog that's dead, it's the BoundNetLog.  it may be that
we're calling into destroyed HostResolverImpl::Jobs.

[maksims (do not use this acc), 2016-08-10 06:43:32]

The CQ bit was checked by maksim.sisov@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 06:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 07:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 07:41:52]

Dry run: This issue passed the CQ dry run.

[maksims (do not use this acc), 2016-08-10 07:48:57]

You're right. That was a BoundNetLog causing troubles.

Surprisingly, the problem was in the OnJobCancelled() method. It set the |job_|
and the |address_| to nullptr and reseted the |callback_|. Once the |callback_|
was reseted, the BoundNetLog was destroyed and the call to LogCancelRequest()
failed. I've just made ~Job() to log first and then call OnJobCancelled(). That
solved the issue.

[mmenke, 2016-08-10 14:33:33]

LGTM!

https://codereview.chromium.org/2214693002/diff/120001/content/browser/render...
File content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
(right):

https://codereview.chromium.org/2214693002/diff/120001/content/browser/render...
content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h:41:
class HostResolver;
Not needed, since you have to include the header here now.

https://codereview.chromium.org/2214693002/diff/120001/net/socket/transport_c...
File net/socket/transport_client_socket_pool.cc (right):

https://codereview.chromium.org/2214693002/diff/120001/net/socket/transport_c...
net/socket/transport_client_socket_pool.cc:120: // ~HostResolver and
~StreamSocket will take care of it.
~HostResolver -> ~HostResolver::Request

[maksims (do not use this acc), 2016-08-11 12:27:59]

The CQ bit was checked by maksim.sisov@intel.com

[maksims (do not use this acc), 2016-08-11 12:27:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2214693002/#ps140001
(title: "single")

[commit-bot: I haz the power, 2016-08-11 12:28:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 12:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 12:34:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[maksims (do not use this acc), 2016-08-12 04:54:06]

maksim.sisov@intel.com changed reviewers:
+ cpu@chromium.org

[maksims (do not use this acc), 2016-08-12 04:55:34]

cpu@, would you please review component/* and content/*?

https://codereview.chromium.org/2214693002/diff/120001/content/browser/render...
File content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
(right):

https://codereview.chromium.org/2214693002/diff/120001/content/browser/render...
content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h:41:
class HostResolver;
On 2016/08/10 14:33:33, mmenke wrote:
> Not needed, since you have to include the header here now.

Done.

https://codereview.chromium.org/2214693002/diff/120001/net/socket/transport_c...
File net/socket/transport_client_socket_pool.cc (right):

https://codereview.chromium.org/2214693002/diff/120001/net/socket/transport_c...
net/socket/transport_client_socket_pool.cc:120: // ~HostResolver and
~StreamSocket will take care of it.
On 2016/08/10 14:33:33, mmenke wrote:
> ~HostResolver -> ~HostResolver::Request

Done.

[maksims (do not use this acc), 2016-08-15 07:43:20]

maksim.sisov@intel.com changed reviewers:
- cpu@chromium.org

[maksims (do not use this acc), 2016-08-15 11:45:28]

maksim.sisov@intel.com changed reviewers:
+ jam@chromium.org

[maksims (do not use this acc), 2016-08-15 11:46:26]

jam@, would you please review components/ and chrome/?

[jam, 2016-08-15 16:32:24]

lgtm

[maksims (do not use this acc), 2016-08-15 16:40:14]

The CQ bit was checked by maksim.sisov@intel.com

[commit-bot: I haz the power, 2016-08-15 16:40:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 18:03:17]

Description was changed from

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

Second part - https://codereview.chromium.org/2212873002/

BUG=630301
==========

to

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

Second part - https://codereview.chromium.org/2212873002/

BUG=630301
==========

[commit-bot: I haz the power, 2016-08-15 18:03:19]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-08-15 18:11:11]

Description was changed from

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

Second part - https://codereview.chromium.org/2212873002/

BUG=630301
==========

to

==========
First step to remove SingleRequestHostResolver.

This cl makes all the callers to use HostResolver instead of
SingleRequestHostResolver. Next cl will remove the class
completely.

Second part - https://codereview.chromium.org/2212873002/

BUG=630301

Committed: https://crrev.com/320d596edc998927c4578323e5c0797963370ae9
Cr-Commit-Position: refs/heads/master@{#411981}
==========

[commit-bot: I haz the power, 2016-08-15 18:11:12]

Patchset 3 (id:??) landed as
https://crrev.com/320d596edc998927c4578323e5c0797963370ae9
Cr-Commit-Position: refs/heads/master@{#411981}