net/dns/host_resolver_impl.cc - Issue 2214693002: First step to remove SingleRequestHostResolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.cc

Issue 2214693002: First step to remove SingleRequestHostResolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: single Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/host_resolver_impl.cc

diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc

index a599adc6bcb7378f75c43583d56e97415c71cd12..2f087ca15712b4f7b1d42c54c8dbe238bdd2b8b3 100644

--- a/net/dns/host_resolver_impl.cc

+++ b/net/dns/host_resolver_impl.cc

@@ -1319,13 +1319,12 @@ class HostResolverImpl::Job : public PrioritizedDispatcher::Job,

net_log_.EndEvent(NetLog::TYPE_HOST_RESOLVER_IMPL_JOB);

}

// else CompleteRequests logged EndEvent.

if (!requests_.empty()) {

// Log any remaining Requests as cancelled.

for (RequestImpl* req : requests_) {

DCHECK_EQ(this, req->job());

- req->OnJobCancelled(this);

LogCancelRequest(req->source_net_log(), req->info());

+ req->OnJobCancelled(this);

}

requests_.clear();

}