Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Side by Side Diff: content/browser/loader/resource_hints_impl.cc

Issue 2214693002: First step to remove SingleRequestHostResolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: single Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ptr_util.h" 5 #include "base/memory/ptr_util.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "content/public/browser/browser_thread.h" 7 #include "content/public/browser/browser_thread.h"
8 #include "content/public/browser/resource_context.h" 8 #include "content/public/browser/resource_context.h"
9 #include "content/public/browser/resource_hints.h" 9 #include "content/public/browser/resource_hints.h"
10 #include "net/base/address_list.h" 10 #include "net/base/address_list.h"
11 #include "net/base/load_flags.h" 11 #include "net/base/load_flags.h"
12 #include "net/dns/host_resolver.h" 12 #include "net/dns/host_resolver.h"
13 #include "net/dns/single_request_host_resolver.h"
14 #include "net/http/http_network_session.h" 13 #include "net/http/http_network_session.h"
15 #include "net/http/http_request_info.h" 14 #include "net/http/http_request_info.h"
16 #include "net/http/http_stream_factory.h" 15 #include "net/http/http_stream_factory.h"
17 #include "net/http/http_transaction_factory.h" 16 #include "net/http/http_transaction_factory.h"
18 #include "net/url_request/http_user_agent_settings.h" 17 #include "net/url_request/http_user_agent_settings.h"
19 #include "net/url_request/url_request_context.h" 18 #include "net/url_request/url_request_context.h"
20 19
21 namespace content { 20 namespace content {
22 21
23 namespace { 22 namespace {
24 23
24 class RequestHolder {
25 public:
26 std::unique_ptr<net::HostResolver::Request>* GetRequest() {
27 return &request_;
28 }
29
30 private:
31 std::unique_ptr<net::HostResolver::Request> request_;
32 };
33
25 // Note that the lifetime of |request| and |addresses| is managed by the caller. 34 // Note that the lifetime of |request| and |addresses| is managed by the caller.
26 void OnResolveComplete(net::SingleRequestHostResolver* request, 35 void OnResolveComplete(RequestHolder* request_holder,
27 net::AddressList* addresses, 36 net::AddressList* addresses,
28 const net::CompletionCallback& callback, 37 const net::CompletionCallback& callback,
29 int result) { 38 int result) {
30 // Plumb the resolution result into the callback if future consumers want 39 // Plumb the resolution result into the callback if future consumers want
31 // that information. 40 // that information.
32 callback.Run(result); 41 callback.Run(result);
33 } 42 }
34 43
35 } // namespace 44 } // namespace
36 45
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 net::HttpStreamFactory* http_stream_factory = session->http_stream_factory(); 83 net::HttpStreamFactory* http_stream_factory = session->http_stream_factory();
75 http_stream_factory->PreconnectStreams(count, request_info); 84 http_stream_factory->PreconnectStreams(count, request_info);
76 } 85 }
77 86
78 int PreresolveUrl(content::ResourceContext* resource_context, 87 int PreresolveUrl(content::ResourceContext* resource_context,
79 const GURL& url, 88 const GURL& url,
80 const net::CompletionCallback& callback) { 89 const net::CompletionCallback& callback) {
81 DCHECK_CURRENTLY_ON(BrowserThread::IO); 90 DCHECK_CURRENTLY_ON(BrowserThread::IO);
82 DCHECK(resource_context); 91 DCHECK(resource_context);
83 92
93 RequestHolder* request_holder = new RequestHolder();
84 net::AddressList* addresses = new net::AddressList; 94 net::AddressList* addresses = new net::AddressList;
85 net::SingleRequestHostResolver* resolver = 95 net::HostResolver* resolver = resource_context->GetHostResolver();
86 new net::SingleRequestHostResolver(resource_context->GetHostResolver());
87 net::HostResolver::RequestInfo resolve_info(net::HostPortPair::FromURL(url)); 96 net::HostResolver::RequestInfo resolve_info(net::HostPortPair::FromURL(url));
88 return resolver->Resolve(resolve_info, net::IDLE, addresses, 97 return resolver->Resolve(
89 base::Bind(&OnResolveComplete, base::Owned(resolver), 98 resolve_info, net::IDLE, addresses,
90 base::Owned(addresses), callback), 99 base::Bind(&OnResolveComplete, base::Owned(request_holder),
91 net::BoundNetLog()); 100 base::Owned(addresses), callback),
101 request_holder->GetRequest(), net::BoundNetLog());
92 } 102 }
93 103
94 } // namespace content 104 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698