Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: net/proxy/proxy_script_decider.cc

Issue 2214693002: First step to remove SingleRequestHostResolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: single Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/proxy_script_decider.h ('k') | net/quic/chromium/quic_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_script_decider.cc
diff --git a/net/proxy/proxy_script_decider.cc b/net/proxy/proxy_script_decider.cc
index 7695b4cbc360a0e3634978a6fffb19cb2b923997..09ba8ced0efbd51af81846c3854c9b2dd999df05 100644
--- a/net/proxy/proxy_script_decider.cc
+++ b/net/proxy/proxy_script_decider.cc
@@ -88,12 +88,12 @@ ProxyScriptDecider::ProxyScriptDecider(
next_state_(STATE_NONE),
net_log_(BoundNetLog::Make(net_log, NetLog::SOURCE_PROXY_SCRIPT_DECIDER)),
fetch_pac_bytes_(false),
- quick_check_enabled_(true) {
+ quick_check_enabled_(true),
+ host_resolver_(nullptr) {
if (proxy_script_fetcher &&
proxy_script_fetcher->GetRequestContext() &&
proxy_script_fetcher->GetRequestContext()->host_resolver()) {
- host_resolver_.reset(new SingleRequestHostResolver(
- proxy_script_fetcher->GetRequestContext()->host_resolver()));
+ host_resolver_ = proxy_script_fetcher->GetRequestContext()->host_resolver();
}
}
@@ -251,7 +251,7 @@ int ProxyScriptDecider::DoWaitComplete(int result) {
int ProxyScriptDecider::DoQuickCheck() {
DCHECK(quick_check_enabled_);
- if (host_resolver_.get() == NULL) {
+ if (host_resolver_ == nullptr) {
// If we have no resolver, skip QuickCheck altogether.
next_state_ = GetStartState();
return OK;
@@ -272,8 +272,8 @@ int ProxyScriptDecider::DoQuickCheck() {
base::Bind(callback, ERR_NAME_NOT_RESOLVED));
// We use HIGHEST here because proxy decision blocks doing any other requests.
- return host_resolver_->Resolve(reqinfo, HIGHEST, &wpad_addresses_,
- callback, net_log_);
+ return host_resolver_->Resolve(reqinfo, HIGHEST, &wpad_addresses_, callback,
+ &request_, net_log_);
}
int ProxyScriptDecider::DoQuickCheckComplete(int result) {
@@ -283,7 +283,7 @@ int ProxyScriptDecider::DoQuickCheckComplete(int result) {
UMA_HISTOGRAM_TIMES("Net.WpadQuickCheckSuccess", delta);
else
UMA_HISTOGRAM_TIMES("Net.WpadQuickCheckFailure", delta);
- host_resolver_->Cancel();
+ request_.reset();
quick_check_timer_.Stop();
if (result != OK)
return TryToFallbackPacSource(result);
« no previous file with comments | « net/proxy/proxy_script_decider.h ('k') | net/quic/chromium/quic_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698