Issue 22144006: Un-revert "Implement simple effect typing for variables" and "Handle switch effects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22144006: Un-revert "Implement simple effect typing for variables" and "Handle switch effects" (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow

Modified:
7 years, 4 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Un-revert "Implement simple effect typing for variables" and "Handle switch effects" This re-lands r15776 and r15777, reverting the revert in r15786. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16071

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+616 lines, -67 lines)			Patch
M	src/ast.h	View		8 chunks	+25 lines, -4 lines	0 comments	Download
A	src/effects.h	View	1	1 chunk	+361 lines, -0 lines	0 comments	Download
M	src/splay-tree.h	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	src/splay-tree-inl.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	src/types.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/typing.h	View		3 chunks	+17 lines, -0 lines	0 comments	Download
M	src/typing.cc	View		24 chunks	+178 lines, -58 lines	0 comments	Download
M	src/zone.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/zone-inl.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	test/cctest/test-global-handles.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

Patch set 1 is the revert of the revert. Patch set 2 is the build ...

7 years, 4 months ago (2013-08-05 15:36:16 UTC) #1

Jakob Kummerow

7 years, 4 months ago (2013-08-06 12:57:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16071 (presubmit successful).