test/cctest/test-global-handles.cc - Issue 22144006: Un-revert "Implement simple effect typing for variables" and "Handle switch effects"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-global-handles.cc

Issue 22144006: Un-revert "Implement simple effect typing for variables" and "Handle switch effects" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix building with clang Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-global-handles.cc

diff --git a/test/cctest/test-global-handles.cc b/test/cctest/test-global-handles.cc

index 3d79dba7aa1d838a09035dacd4f1947a2116a528..10a1d7986e1459c34ccf586ab1fc0132f32eda40 100644

--- a/test/cctest/test-global-handles.cc

+++ b/test/cctest/test-global-handles.cc

@@ -418,7 +418,7 @@ class RandomMutationData {

int32_t offset = ++weak_offset_;

object->Set(7, v8::Integer::New(offset, isolate));

v8::Persistent<v8::Object> persistent(isolate, object);

- persistent.MakeWeak(isolate, this, WeakCallback);

+ persistent.MakeWeak(this, WeakCallback);

persistent.MarkIndependent();

Object** location = v8::Utils::OpenPersistent(persistent).location();

bool inserted =

« no previous file with comments | « src/zone-inl.h ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »