Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce unserializableValue in RemoteObject. It carries primitive values which cannot be JSON-stringified. Added support for it in more places on frontend side. BUG=631162 Committed: https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69 Cr-Commit-Position: refs/heads/master@{#409981}

Patch Set 1 #

Patch Set 2 : hidden #

Total comments: 2

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
4 years, 4 months ago (2016-08-04 21:21:33 UTC) #2
kozy
lgtm https://codereview.chromium.org/2214193002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/2214193002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js#newcode353 third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:353: if (typeof object.unserializableValue !== "undefined") Why do you ...
4 years, 4 months ago (2016-08-05 01:21:02 UTC) #3
dgozman
https://codereview.chromium.org/2214193002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js File third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/2214193002/diff/20001/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js#newcode353 third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js:353: if (typeof object.unserializableValue !== "undefined") On 2016/08/05 01:21:02, kozyatinskiy ...
4 years, 4 months ago (2016-08-05 02:01:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214193002/20001
4 years, 4 months ago (2016-08-05 02:02:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-05 03:28:02 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 03:30:23 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1a8571b602f826acc09f0e6220c04c39fb12be69
Cr-Commit-Position: refs/heads/master@{#409981}

Powered by Google App Engine
This is Rietveld 408576698