third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js - Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: hidden Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

index bccd668f2ce314650e94ffc26c74e4a7a1b7d52c..1c972b3196ed128e7c8720249fba1d6722ca7d43 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

@@ -716,13 +716,13 @@ InjectedScript.RemoteObject = function(object, objectGroupName, doNotBind, force

// Provide user-friendly number values.

if (this.type === "number") {

this.description = toStringDescription(object);

- // Override "value" property for values that can not be JSON-stringified.

switch (this.description) {

case "NaN":

case "Infinity":

case "-Infinity":

case "-0":

- this.value = this.description;

+ delete this.value;

+ this.unserializableValue = this.description;

break;

}