third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js - Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js

Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: hidden Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async.html ('k') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js b/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js

index d34516f1df822579ae6c2f43a02abc7fa0f024a0..6ee83f3f6ea8035daedc53cce2fd5c5b195abbbb 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js

@@ -48,9 +48,15 @@ WebInspector.InspectorBackendHostedMode.generateCommands = function(schema)

var members = [];

for (var m = 0; m < items.length; ++m) {

var value = items[m];

- var name = value.replace(/-(\w)/g, toUpperCase.bind(null, 1)).toTitleCase();

+ var name = value;

+ var prefix = "";

+ if (name[0] === "-") {

+ prefix = "Negative";

+ name = name.substring(1);

+ }

+ name = name.replace(/-(\w)/g, toUpperCase.bind(null, 1)).toTitleCase();

name = name.replace(/HTML|XML|WML|API/ig, toUpperCase.bind(null, 0));

- members.push(name + ": \"" + value + "\"");

+ members.push(prefix + name + ": \"" + value + "\"");

}

return "InspectorBackend.registerEnum(\"" + enumName + "\", {" + members.join(", ") + "});";

}