third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py - Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py

Issue 2214193002: [DevTools] Introduce unserializableValue in RemoteObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: hidden Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js ('K') | « third_party/WebKit/Source/devtools/scripts/CodeGeneratorFrontend.py ('k') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py

diff --git a/third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py b/third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py

index d0029c083237d59e2451aa94e1c163f2be95f523..cf98a2fbef1951c240b516891768c780e2428b08 100755

--- a/third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py

+++ b/third_party/WebKit/Source/devtools/scripts/generate_protocol_externs.py

@@ -61,9 +61,13 @@ def full_qualified_type_id(domain_name, type_id):

def fix_camel_case(name):

+ prefix = ""

+ if name[0] == "-":

+ prefix = "Negative"

+ name = name[1:]

refined = re.sub(r'-(\w)', lambda pat: pat.group(1).upper(), name)

refined = to_title_case(refined)

- return re.sub(r'(?i)HTML|XML|WML|API', lambda pat: pat.group(0).upper(), refined)

+ return prefix + re.sub(r'(?i)HTML|XML|WML|API', lambda pat: pat.group(0).upper(), refined)

def to_title_case(name):