Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed)

Created:
6 years, 8 months ago by vandebo (ex-Chrome)
Modified:
6 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make unknown extension subpermissions warnings instead of errors. BUG=349058 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261406

Patch Set 1 #

Total comments: 5

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -107 lines) Patch
M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/media_galleries_permission_unittest.cc View 1 8 chunks +67 lines, -61 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/permissions/socket_permission_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/usb_device_permission_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/api_permission.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/common/permissions/api_permission_set.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/permissions/api_permission_set_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M extensions/common/permissions/media_galleries_permission.h View 1 chunk +4 lines, -1 line 0 comments Download
M extensions/common/permissions/media_galleries_permission.cc View 1 chunk +15 lines, -4 lines 0 comments Download
M extensions/common/permissions/set_disjunction_permission.h View 1 3 chunks +19 lines, -8 lines 0 comments Download
M extensions/common/permissions/settings_override_permission.h View 1 chunk +4 lines, -1 line 0 comments Download
M extensions/common/permissions/settings_override_permission.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
vandebo (ex-Chrome)
https://codereview.chromium.org/221353003/diff/1/extensions/common/permissions/set_disjunction_permission.h File extensions/common/permissions/set_disjunction_permission.h (right): https://codereview.chromium.org/221353003/diff/1/extensions/common/permissions/set_disjunction_permission.h#newcode140 extensions/common/permissions/set_disjunction_permission.h:140: unhandled = true; This is the meat of the ...
6 years, 8 months ago (2014-04-01 23:11:03 UTC) #1
Yoyo Zhou
LGTM but could use tests https://chromiumcodereview.appspot.com/221353003/diff/1/chrome/common/extensions/permissions/media_galleries_permission_unittest.cc File chrome/common/extensions/permissions/media_galleries_permission_unittest.cc (right): https://chromiumcodereview.appspot.com/221353003/diff/1/chrome/common/extensions/permissions/media_galleries_permission_unittest.cc#newcode30 chrome/common/extensions/permissions/media_galleries_permission_unittest.cc:30: TEST(MediaGalleriesPermissionTest, GoodValues) { Maybe ...
6 years, 8 months ago (2014-04-02 00:31:31 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/221353003/diff/1/chrome/common/extensions/permissions/media_galleries_permission_unittest.cc File chrome/common/extensions/permissions/media_galleries_permission_unittest.cc (right): https://codereview.chromium.org/221353003/diff/1/chrome/common/extensions/permissions/media_galleries_permission_unittest.cc#newcode30 chrome/common/extensions/permissions/media_galleries_permission_unittest.cc:30: TEST(MediaGalleriesPermissionTest, GoodValues) { On 2014/04/02 00:31:31, Yoyo Zhou wrote: ...
6 years, 8 months ago (2014-04-02 16:46:59 UTC) #3
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 8 months ago (2014-04-02 16:47:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/221353003/20001
6 years, 8 months ago (2014-04-02 16:47:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 16:53:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-02 16:53:24 UTC) #7
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 8 months ago (2014-04-02 17:46:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/221353003/20001
6 years, 8 months ago (2014-04-02 17:49:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 03:38:59 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=61795
6 years, 8 months ago (2014-04-03 03:38:59 UTC) #11
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 8 months ago (2014-04-03 15:23:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/221353003/20001
6 years, 8 months ago (2014-04-03 15:23:02 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:24:35 UTC) #14
Message was sent while issue was closed. 
Change committed as 261406

Powered by Google App Engine
This is Rietveld 408576698