Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: extensions/common/permissions/set_disjunction_permission.h

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/set_disjunction_permission.h
diff --git a/extensions/common/permissions/set_disjunction_permission.h b/extensions/common/permissions/set_disjunction_permission.h
index 3a3e9c575296a63d8530f87160c1eda48976afec..89295c36c004f6a7d359f1a14ebd13ac40bbc320 100644
--- a/extensions/common/permissions/set_disjunction_permission.h
+++ b/extensions/common/permissions/set_disjunction_permission.h
@@ -9,6 +9,7 @@
#include <set>
#include <string>
+#include "base/json/json_writer.h"
#include "base/memory/scoped_ptr.h"
#include "base/values.h"
#include "extensions/common/extension_messages.h"
@@ -112,8 +113,10 @@ class SetDisjunctionPermission : public APIPermission {
return result->data_set_.empty() ? NULL : result.release();
}
- virtual bool FromValue(const base::Value* value,
- std::string* error) OVERRIDE {
+ virtual bool FromValue(
+ const base::Value* value,
+ std::string* error,
+ std::vector<std::string>* unhandled_permissions) OVERRIDE {
data_set_.clear();
const base::ListValue* list = NULL;
@@ -130,13 +133,21 @@ class SetDisjunctionPermission : public APIPermission {
DCHECK(item_value);
PermissionDataType data;
- if (!data.FromValue(item_value)) {
- if (error)
- *error = "Cannot parse an item from the permission list";
- return false;
+ if (data.FromValue(item_value)) {
+ data_set_.insert(data);
+ } else {
+ std::string unknown_permission;
+ base::JSONWriter::Write(item_value, &unknown_permission);
+ if (unhandled_permissions) {
+ unhandled_permissions->push_back(unknown_permission);
+ } else {
+ if (error) {
+ *error = "Cannot parse an item from the permission list: " +
+ unknown_permission;
+ }
+ return false;
+ }
}
-
- data_set_.insert(data);
}
return true;
}

Powered by Google App Engine
This is Rietveld 408576698