chrome/common/extensions/permissions/usb_device_permission_unittest.cc - Issue 221353003: Make unknown extension subpermissions warnings instead of errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/usb_device_permission_unittest.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/socket_permission_unittest.cc ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/usb_device_permission_unittest.cc

diff --git a/chrome/common/extensions/permissions/usb_device_permission_unittest.cc b/chrome/common/extensions/permissions/usb_device_permission_unittest.cc

index e64d429ddbf38c651ace7cc2fa3efd6eed7080ce..dcf066c72a1d73b27ec1ce3f37d999cea9cb57ee 100644

--- a/chrome/common/extensions/permissions/usb_device_permission_unittest.cc

+++ b/chrome/common/extensions/permissions/usb_device_permission_unittest.cc

@@ -51,7 +51,7 @@ TEST(USBDevicePermissionTest, MAYBE_PermissionMessage) {

UsbDevicePermission permission(

PermissionsInfo::GetInstance()->GetByID(APIPermission::kUsbDevice));

- ASSERT_TRUE(permission.FromValue(permission_list.get(), NULL));

+ ASSERT_TRUE(permission.FromValue(permission_list.get(), NULL, NULL));

PermissionMessages messages = permission.GetMessages();

ASSERT_EQ(3U, messages.size());