chrome/browser/extensions/extension_prefs_unittest.cc - Issue 221353003: Make unknown extension subpermissions warnings instead of errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_prefs_unittest.cc

Issue 221353003: Make unknown extension subpermissions warnings instead of errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_prefs_unittest.cc

diff --git a/chrome/browser/extensions/extension_prefs_unittest.cc b/chrome/browser/extensions/extension_prefs_unittest.cc

index 8b2f41ebafe3555dd66fe42ef2f19a34515c4de5..9067ed475f5489cce3db55fbc444b702ad0f8ed1 100644

--- a/chrome/browser/extensions/extension_prefs_unittest.cc

+++ b/chrome/browser/extensions/extension_prefs_unittest.cc

@@ -200,7 +200,7 @@ class ExtensionPrefsGrantedPermissions : public ExtensionPrefsTest {

value->Append(new base::StringValue("tcp-connect:*.example.com:80"));

value->Append(new base::StringValue("udp-bind::8080"));

value->Append(new base::StringValue("udp-send-to::8888"));

- ASSERT_TRUE(permission->FromValue(value.get(), NULL));

+ ASSERT_TRUE(permission->FromValue(value.get(), NULL, NULL));

}

api_perm_set1_.insert(permission.release());