Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2211813002: Revert removal of grammar checking and marking code (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, groby+blinkspell_chromium.org, Nate Chapin, jochen+watch_chromium.org, kinuko+watch, loading-reviews_chromium.org, mlamouri+watch-test-runner_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert removal of grammar checking and marking code This is a manual revert of the following commits: Revert "Remove layout tests only for grammar checking" This reverts commit 32de271fb02024450856b9a5dcfbe42609739224. Revert "Remove grammar checking from layout tests, and MockGrammarCheck" This reverts commit 57b84ed8f4c1df5564ae573459287ce55569dab3. Revert "Auto-rebaseline for r408347" This reverts commit b8af511d0bb6a78352b434c4dede88f9348650c6. Revert "Remove expectation images incorrectly added by autorebaseline bot" This reverts commit 537eb21a213e933eadc4cb5261bd33f5b895d08d. Revert "Remove grammar marker inspection from WebFrameTest" This reverts commit ca4b6d233d131487b752e5c92ff16f56779b3f7a. Revert "Stop TextCheckingHelper from checking grammar" This reverts commit 068b312e9d944f8fdb4090355b93ab3e87f9a99b. Revert "Hide some member functions of SpellChecker as private" This reverts commit 01554f3c62b7725817c766dd620e302fcdad6e00. Revert "Remove some grammar checking code from SpellChecker" This reverts commit 9491bd6d99971bbc3ce80d4ea406e2b3c42f6fb2. Revert "Remove grammar checking from markAllMisspellingsAndBadGrammarInRanges" This reverts commit 91ca178d41af494fd444fad6a44202d1d31388c6. Revert "Remove some further grammar checking code from SpellChecker" This reverts commit 579c127d36de5035a5084b9aa88697f18b0a4552. Revert "Remove grammar checking from SpellChecker::markMisspellingsAndBadGrammar" This reverts commit 0f9281dc5ff0e3a92e3be32b1b096e3539c66bf9. Revert "Remove grammar checking from SpellChecker::chunkAndMarkAllMisspellingsAndBadGrammar" This reverts commit 7095e1641402c57f32d2cc952b4357af13ff8dfc. Revert "Cleanup function names in SpellChecker and TextCheckingHelper" This reverts commit a10daeeca303db977aa23218f2ac71abbb2eaa2e. BUG=619452, 633641 TBR=yosin@chromium.org, tkent@chromium.org Committed: https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e Cr-Commit-Position: refs/heads/master@{#409763}

Patch Set 1 #

Patch Set 2 : Minor fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1046 lines, -125 lines) Patch
M components/test_runner/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/test_runner/mock_grammar_check.h View 1 chunk +30 lines, -0 lines 0 comments Download
A components/test_runner/mock_grammar_check.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M components/test_runner/spell_check_client.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M components/test_runner/test_runner.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +1 line, -3 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar.html View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/spelling/grammar-paste.html View 4 chunks +67 lines, -28 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/spelling/grammar-paste-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited-expected.txt View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-expected.txt View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers-expected.txt View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/markers.html View 3 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/markers-expected.txt View 2 chunks +6 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/linux/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/mac/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/platform/win/editing/spelling/grammar-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline-spelling-markers-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/editing/spelling/inline_spelling_markers-expected.png View Binary file 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h View 2 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 19 chunks +214 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp View 4 chunks +274 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/TextCheckerClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/SpellCheckerClientImpl.cpp View 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2211813002/20001
4 years, 4 months ago (2016-08-04 08:46:45 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 11:53:27 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 11:54:53 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/580e9d52a44e15cc8e92673fc763cb47caa3717e
Cr-Commit-Position: refs/heads/master@{#409763}

Powered by Google App Engine
This is Rietveld 408576698