third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2211813002: Revert removal of grammar checking and marking code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2211813002: Revert removal of grammar checking and marking code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index cbc0247869c9921ce1ddb6d17ddae0178e20b19c..046bf4ed70bd5a29694e73c8b6dc05b3dda0934e 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -1336,7 +1336,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap

// FIXME (5098931): We should add a new insert action "WebViewInsertActionMoved" and call shouldInsertFragment here.

setEndingSelection(VisibleSelection(start, end));

- document().frame()->spellChecker().clearMisspellings(endingSelection());

+ document().frame()->spellChecker().clearMisspellingsAndBadGrammar(endingSelection());

deleteSelection(editingState, false, false, false);

if (editingState->isAborted())

return;

@@ -1381,7 +1381,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap

if (editingState->isAborted())

return;

- document().frame()->spellChecker().markMisspellings(endingSelection());

+ document().frame()->spellChecker().markMisspellingsAndBadGrammar(endingSelection());

// If the selection is in an empty paragraph, restore styles from the old empty paragraph to the new empty paragraph.

bool selectionIsEmptyParagraph = endingSelection().isCaret() && isStartOfParagraph(endingSelection().visibleStart()) && isEndOfParagraph(endingSelection().visibleStart());