third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h - Issue 2211813002: Revert removal of grammar checking and marking code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

Issue 2211813002: Revert removal of grammar checking and marking code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp ('k') | third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

diff --git a/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

index 0d85d37ae67038ec798c0ba956f072756e79d735..a7c9a204ab31603c16219323f2d01d87efb89fe6 100644

--- a/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

+++ b/third_party/WebKit/Source/core/editing/spellcheck/TextCheckingHelper.h

@@ -89,13 +89,17 @@ public:

~TextCheckingHelper();

String findFirstMisspelling(int& firstMisspellingOffset, bool markAll);

+ String findFirstMisspellingOrBadGrammar(bool& outIsSpelling, int& outFirstFoundOffset, GrammarDetail& outGrammarDetail);

+ String findFirstBadGrammar(GrammarDetail& outGrammarDetail, int& outGrammarPhraseOffset, bool markAll);

bool markAllMisspellings();

+ void markAllBadGrammar();

private:

SpellCheckerClient* m_client;

Position m_start;

Position m_end;

+ int findFirstGrammarDetail(const Vector<GrammarDetail>& grammarDetails, int badGrammarPhraseLocation, int startOffset, int endOffset, bool markAll) const;

bool unifiedTextCheckerEnabled() const;

};