Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h

Issue 2211813002: Revert removal of grammar checking and marking code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
index 173530b791bd2d0aeb7dd303fc3c85758bbe9b8c..a02d78ce6dde63e5133b86b8a148417a9c27f58d 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.h
@@ -61,24 +61,29 @@ public:
static bool isSpellCheckingEnabledFor(const VisibleSelection&);
void markMisspellingsAfterLineBreak(const VisibleSelection& wordSelection);
void markMisspellingsAfterTypingToWord(const VisiblePosition &wordStart, const VisibleSelection& selectionAfterTyping);
+ bool markMisspellings(const VisibleSelection&);
+ void markBadGrammar(const VisibleSelection&);
+ void markMisspellingsAndBadGrammar(const VisibleSelection& spellingSelection, bool markGrammar, const VisibleSelection& grammarSelection);
void markAndReplaceFor(SpellCheckRequest*, const Vector<TextCheckingResult>&);
+ void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask, const EphemeralRange& spellingRange, const EphemeralRange& grammarRange);
void advanceToNextMisspelling(bool startBeforeSelection = false);
void showSpellingGuessPanel();
void didBeginEditing(Element*);
- void clearMisspellings(const VisibleSelection&);
- void markMisspellings(const VisibleSelection&);
+ void clearMisspellingsAndBadGrammar(const VisibleSelection&);
+ void markMisspellingsAndBadGrammar(const VisibleSelection&);
void respondToChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions);
void replaceMisspelledRange(const String&);
void removeSpellingMarkers();
void removeSpellingMarkersUnderWords(const Vector<String>& words);
void spellCheckAfterBlur();
+ void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
void didEndEditingOnTextField(Element*);
bool selectionStartHasMarkerFor(DocumentMarker::MarkerType, int from, int length) const;
bool selectionStartHasSpellingMarkerFor(int from, int length) const;
void updateMarkersForWordsAffectedByEditing(bool onlyHandleWordsContainingSelection);
void cancelCheck();
- void chunkAndMarkAllMisspellings(Node*, const EphemeralRange&);
+ void chunkAndMarkAllMisspellingsAndBadGrammar(Node*, const EphemeralRange&);
void requestTextChecking(const Element&);
// Exposed for testing only
@@ -101,14 +106,13 @@ private:
return *m_frame;
}
- void markMisspellingsWithTextCheckingHelper(const VisibleSelection&);
- void markAllMisspellingsInRange(const EphemeralRange& spellingRange);
- void spellCheckOldSelection(const VisibleSelection& oldSelection, const VisibleSelection& newAdjacentWords);
+ bool markMisspellingsOrBadGrammar(const VisibleSelection&, bool checkSpelling);
+ TextCheckingTypeMask resolveTextCheckingTypeMask(TextCheckingTypeMask);
void removeMarkers(const VisibleSelection&, DocumentMarker::MarkerTypes);
bool unifiedTextCheckerEnabled() const;
- void chunkAndMarkAllMisspellings(const TextCheckingParagraph& fullParagraphToCheck);
+ void chunkAndMarkAllMisspellingsAndBadGrammar(TextCheckingTypeMask textCheckingOptions, const TextCheckingParagraph& fullParagraphToCheck);
Member<LocalFrame> m_frame;
const Member<SpellCheckRequester> m_spellCheckRequester;

Powered by Google App Engine
This is Rietveld 408576698