content/browser/site_instance_impl_unittest.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/site_instance_impl_unittest.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_manager_impl_unittest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/browser/tracing/etw_tracing_agent_win.cc » ('j') | extensions/shell/test/shell_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/site_instance_impl_unittest.cc

diff --git a/content/browser/site_instance_impl_unittest.cc b/content/browser/site_instance_impl_unittest.cc

index be2a3eea4dc58d0a7749e8bf56afe1d02d7e3903..2c279a9573861f7bf534cb983b88b36a65f1086c 100644

--- a/content/browser/site_instance_impl_unittest.cc

+++ b/content/browser/site_instance_impl_unittest.cc

@@ -138,7 +138,7 @@ class SiteInstanceTest : public testing::Test {

// objects in each test, which will be destructed before

// TearDown() is called.

base::RunLoop().RunUntilIdle();

- message_loop_.RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

fdoray 2016/08/04 18:48:21 Why are there 2 calls?

gab 2016/08/05 01:09:57 Probably because the developer thought he was flus

fdoray 2016/08/05 16:10:36 Done. https://codereview.chromium.org/2219053002/

}

SiteInstanceTestBrowserClient* browser_client() { return &browser_client_; }