extensions/shell/test/shell_test.cc - Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/test/shell_test.cc

Issue 2211473003: Remove calls to deprecated MessageLoop methods on Windows and Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/site_instance_impl_unittest.cc ('K') | « extensions/browser/api/declarative/rules_registry_unittest.cc ('k') | gpu/tools/compositor_model_bench/compositor_model_bench.cc » ('j') | media/audio/win/audio_low_latency_input_win_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/test/shell_test.cc

diff --git a/extensions/shell/test/shell_test.cc b/extensions/shell/test/shell_test.cc

index 96ebb2a69441fd8adaee050cd2cafb93f0d97113..549e24ab61079e8ca8932c4716dfb11dc94ced5b 100644

--- a/extensions/shell/test/shell_test.cc

+++ b/extensions/shell/test/shell_test.cc

@@ -9,6 +9,7 @@

#include "base/files/file_path.h"

#include "base/logging.h"

#include "base/path_service.h"

+#include "base/run_loop.h"

#include "build/build_config.h"

#include "components/version_info/version_info.h"

#include "content/public/common/content_switches.h"

@@ -57,7 +58,7 @@ void AppShellTest::SetUpOnMainThread() {

}

void AppShellTest::RunTestOnMainThreadLoop() {

- base::MessageLoopForUI::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

gab 2016/08/05 01:09:57 Why didn't the script add a DCHECK IsMessageLoopFo

fdoray 2016/08/05 16:10:36 Done. I added these DCHECKs manually.

SetUpOnMainThread();