mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155, 629257
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org

Committed: https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105
Cr-Commit-Position: refs/heads/master@{#409671}

[msw, 2016-08-03 17:12:14]

Description was changed from

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types.
Simple move with updated includes.

BUG=615155
TEST=Automated; no cros task manager (etc.) shelf item changes.
==========

to

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

This is a simple move with updated includes.

BUG=615155
TEST=Automated; no cros task manager (etc.) shelf item changes.
==========

[msw, 2016-08-03 18:36:59]

Description was changed from

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

This is a simple move with updated includes.

BUG=615155
TEST=Automated; no cros task manager (etc.) shelf item changes.
==========

to

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org
==========

[msw, 2016-08-03 18:36:59]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-08-03 18:38:13]

Description was changed from

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org
==========

to

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155,629257
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org
==========

[msw, 2016-08-03 18:38:25]

Hey Scott, please take a look; thanks!

[msw, 2016-08-03 18:38:34]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:39:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 19:52:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:52:52]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-03 21:36:59]

LGTM

https://codereview.chromium.org/2211463002/diff/40001/ash/mus/bridge/wm_windo...
File ash/mus/bridge/wm_window_mus.cc (right):

https://codereview.chromium.org/2211463002/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus.cc:363: NOTIMPLEMENTED();
I encourage you to file bugs for these and reference them here.

[msw, 2016-08-03 21:51:27]

https://codereview.chromium.org/2211463002/diff/40001/ash/mus/bridge/wm_windo...
File ash/mus/bridge/wm_window_mus.cc (right):

https://codereview.chromium.org/2211463002/diff/40001/ash/mus/bridge/wm_windo...
ash/mus/bridge/wm_window_mus.cc:363: NOTIMPLEMENTED();
On 2016/08/03 21:36:59, sky wrote:
> I encourage you to file bugs for these and reference them here.

Done.

[msw, 2016-08-03 21:51:33]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-03 21:51:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2211463002/#ps60001
(title: "Add TODO comments with bug for WmWindowMus ShelfItemDetails support.")

[commit-bot: I haz the power, 2016-08-03 21:52:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 22:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:14:41]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[msw, 2016-08-03 22:25:13]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-08-03 22:25:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 23:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 23:23:06]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-08-03 23:27:21]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-08-03 23:27:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 23:59:59]

Description was changed from

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155,629257
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org
==========

to

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155,629257
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-08-04 00:00:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-04 00:01:50]

Description was changed from

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155,629257
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org
==========

to

==========
mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common.

James already converted these to ash common types in:
  https://codereview.chromium.org/2192553002

Convert the tests to common types and move all to ash/common.
Add WmWindow::[Set|Clear]ShelfItemDetails (Get* already added).

Move ShelfWindowWatcher ownership to WmShell.

BUG=615155,629257
TEST=Automated; no cros task manager (etc.) shelf item changes.
R=sky@chromium.org

Committed: https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105
Cr-Commit-Position: refs/heads/master@{#409671}
==========

[commit-bot: I haz the power, 2016-08-04 00:01:51]

Patchset 4 (id:??) landed as
https://crrev.com/757a8f0c8a59d4dd16ad8821a19fa2f1609c0105
Cr-Commit-Position: refs/heads/master@{#409671}