mash: Convert ShelfWindowWatcher to wm common types

mash: Convert ShelfWindowWatcher to wm common types

This also simplifies the behavior of ShelfWindowWatcher:
* It adds an icon to the shelf if a window with ShelfItemDetails is created in
the default window container.
* It leaves the icon there until the window is closed, even if the window is
reparented during a drag or dock operation.

This eliminates one set of window observers.

TODO: Change ownership to WmShell and move to //ash/common

BUG=629257
TEST=added to ash_unittests

Committed: https://crrev.com/47d35c03fb047de36bf7a26dc1beb80d572f7696
Cr-Commit-Position: refs/heads/master@{#408236}

[James Cook, 2016-07-27 17:21:04]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 17:21:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-27 17:21:42]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-27 17:21:43]

msw, please take a look.

[commit-bot: I haz the power, 2016-07-27 17:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 17:59:39]

Dry run: This issue passed the CQ dry run.

[msw, 2016-07-27 18:36:11]

lgtm with nits and a test question.

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.cc (right):

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:151: // display or because it an existing
window added ShelfItemDetails to itself.
nit: "it an"

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:160:
window->GetIntProperty(WmWindowProperty::SHELF_ID) == kInvalidShelfID)
nit: curlies

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.h (right):

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.h:81: // Adds a shelf item for new windows with a
ShelfItemDetails property that
nit: "Adds a shelf item for new windows added to the default container with a
ShelfItemDetails property."

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher_unittest.cc (right):

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:65: // Create a ShelfItem for w1.
Is it possible to test that items are created when the windows are added to the
default container (perhaps instead of explicitly adding items like this)?

[James Cook, 2016-07-27 20:14:06]

msw, please take another look (I added a few lines of code to the tests).

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.cc (right):

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:151: // display or because it an existing
window added ShelfItemDetails to itself.
On 2016/07/27 18:36:10, msw wrote:
> nit: "it an"

Done.

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.cc:160:
window->GetIntProperty(WmWindowProperty::SHELF_ID) == kInvalidShelfID)
On 2016/07/27 18:36:10, msw wrote:
> nit: curlies

Done.

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher.h (right):

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher.h:81: // Adds a shelf item for new windows with a
ShelfItemDetails property that
On 2016/07/27 18:36:10, msw wrote:
> nit: "Adds a shelf item for new windows added to the default container with a
> ShelfItemDetails property."

Done.

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_watcher_unittest.cc (right):

https://codereview.chromium.org/2192553002/diff/20001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_watcher_unittest.cc:65: // Create a ShelfItem for w1.
On 2016/07/27 18:36:11, msw wrote:
> Is it possible to test that items are created when the windows are added to
the
> default container (perhaps instead of explicitly adding items like this)?

Done (and thanks for the suggestion, it's better). I didn't convert all the
other tests to this approach, since if the CreateAndRemoveShelfItemDetails test
passes then the other tests should be OK with adding the details after window
creation.

[James Cook, 2016-07-27 20:14:13]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 20:14:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-27 20:28:01]

nice; lgtm!

[James Cook, 2016-07-27 20:32:43]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-07-27 20:32:47]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:32:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 21:08:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 21:09:38]

Description was changed from

==========
mash: Convert ShelfWindowWatcher to wm common types

This also simplifies the behavior of ShelfWindowWatcher:
* It adds an icon to the shelf if a window with ShelfItemDetails is created in
the default window container.
* It leaves the icon there until the window is closed, even if the window is
reparented during a drag or dock operation.

This eliminates one set of window observers.

TODO: Change ownership to WmShell and move to //ash/common

BUG=629257
TEST=added to ash_unittests
==========

to

==========
mash: Convert ShelfWindowWatcher to wm common types

This also simplifies the behavior of ShelfWindowWatcher:
* It adds an icon to the shelf if a window with ShelfItemDetails is created in
the default window container.
* It leaves the icon there until the window is closed, even if the window is
reparented during a drag or dock operation.

This eliminates one set of window observers.

TODO: Change ownership to WmShell and move to //ash/common

BUG=629257
TEST=added to ash_unittests

Committed: https://crrev.com/47d35c03fb047de36bf7a26dc1beb80d572f7696
Cr-Commit-Position: refs/heads/master@{#408236}
==========

[commit-bot: I haz the power, 2016-07-27 21:09:40]

Patchset 3 (id:??) landed as
https://crrev.com/47d35c03fb047de36bf7a26dc1beb80d572f7696
Cr-Commit-Position: refs/heads/master@{#408236}