Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: ash/mus/bridge/wm_window_mus.cc

Issue 2211463002: mash: Move ShelfWindowWatcher[ItemDelegate] to ash/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO comments with bug for WmWindowMus ShelfItemDetails support. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/mus/bridge/wm_window_mus.h ('k') | ash/shelf/shelf_window_watcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/mus/bridge/wm_window_mus.h" 5 #include "ash/mus/bridge/wm_window_mus.h"
6 6
7 #include "ash/common/wm/container_finder.h" 7 #include "ash/common/wm/container_finder.h"
8 #include "ash/common/wm/window_state.h" 8 #include "ash/common/wm/window_state.h"
9 #include "ash/common/wm_layout_manager.h" 9 #include "ash/common/wm_layout_manager.h"
10 #include "ash/common/wm_window_observer.h" 10 #include "ash/common/wm_window_observer.h"
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 void WmWindowMus::SetIntProperty(WmWindowProperty key, int value) { 348 void WmWindowMus::SetIntProperty(WmWindowProperty key, int value) {
349 if (key == WmWindowProperty::SHELF_ID) { 349 if (key == WmWindowProperty::SHELF_ID) {
350 NOTIMPLEMENTED(); 350 NOTIMPLEMENTED();
351 return; 351 return;
352 } 352 }
353 353
354 NOTREACHED(); 354 NOTREACHED();
355 } 355 }
356 356
357 ShelfItemDetails* WmWindowMus::GetShelfItemDetails() { 357 ShelfItemDetails* WmWindowMus::GetShelfItemDetails() {
358 NOTIMPLEMENTED(); 358 NOTIMPLEMENTED(); // TODO: Add support; see crbug.com/634150
359 return nullptr; 359 return nullptr;
360 } 360 }
361 361
362 void WmWindowMus::SetShelfItemDetails(const ShelfItemDetails& details) {
363 NOTIMPLEMENTED(); // TODO: Add support; see crbug.com/634150
364 }
365
366 void WmWindowMus::ClearShelfItemDetails() {
367 NOTIMPLEMENTED(); // TODO: Add support; see crbug.com/634150
368 }
369
362 const wm::WindowState* WmWindowMus::GetWindowState() const { 370 const wm::WindowState* WmWindowMus::GetWindowState() const {
363 return window_state_.get(); 371 return window_state_.get();
364 } 372 }
365 373
366 WmWindow* WmWindowMus::GetToplevelWindow() { 374 WmWindow* WmWindowMus::GetToplevelWindow() {
367 return WmShellMus::GetToplevelAncestor(window_); 375 return WmShellMus::GetToplevelAncestor(window_);
368 } 376 }
369 377
370 WmWindow* WmWindowMus::GetToplevelWindowForFocus() { 378 WmWindow* WmWindowMus::GetToplevelWindowForFocus() {
371 // TODO(sky): resolve if we really need two notions of top-level. In the mus 379 // TODO(sky): resolve if we really need two notions of top-level. In the mus
(...skipping 446 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 void WmWindowMus::OnWindowDestroying(ui::Window* window) { 826 void WmWindowMus::OnWindowDestroying(ui::Window* window) {
819 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this)); 827 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroying(this));
820 } 828 }
821 829
822 void WmWindowMus::OnWindowDestroyed(ui::Window* window) { 830 void WmWindowMus::OnWindowDestroyed(ui::Window* window) {
823 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroyed(this)); 831 FOR_EACH_OBSERVER(WmWindowObserver, observers_, OnWindowDestroyed(this));
824 } 832 }
825 833
826 } // namespace mus 834 } // namespace mus
827 } // namespace ash 835 } // namespace ash
OLDNEW
« no previous file with comments | « ash/mus/bridge/wm_window_mus.h ('k') | ash/shelf/shelf_window_watcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698