Move to SkDataTable::MakeXXX and sk_sp.

Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.

Committed: https://skia.googlesource.com/skia/+/feb3c1a57faee39dc10ac904f6b215ba50e286b4

[bungeman-skia, 2016-08-04 18:38:51]

Description was changed from

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
==========

to

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211143002
==========

[bungeman-skia, 2016-08-04 18:43:40]

Description was changed from

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211143002
==========

to

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
==========

[bungeman-skia, 2016-08-04 18:44:47]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 18:44:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-04 19:03:11]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[bungeman-skia, 2016-08-04 19:03:30]

bungeman@google.com changed reviewers:
+ reed@google.com

[commit-bot: I haz the power, 2016-08-04 19:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 19:14:50]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-08-04 19:23:41]

https://codereview.chromium.org/2211143002/diff/1/src/core/SkDataTable.cpp
File src/core/SkDataTable.cpp (right):

https://codereview.chromium.org/2211143002/diff/1/src/core/SkDataTable.cpp#ne...
src/core/SkDataTable.cpp:81: static sk_sp<SkDataTable> singleton;
I think we usually keep singletons as raw pointers, so as to avoid global
destructors.  Am I remembering that wrong?

[bungeman-skia, 2016-08-04 19:48:23]

Description was changed from

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
==========

to

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211143002
==========

[bungeman-skia, 2016-08-04 19:48:47]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[bungeman-skia, 2016-08-04 19:48:52]

https://codereview.chromium.org/2211143002/diff/1/src/core/SkDataTable.cpp
File src/core/SkDataTable.cpp (right):

https://codereview.chromium.org/2211143002/diff/1/src/core/SkDataTable.cpp#ne...
src/core/SkDataTable.cpp:81: static sk_sp<SkDataTable> singleton;
On 2016/08/04 19:23:41, mtklein wrote:
> I think we usually keep singletons as raw pointers, so as to avoid global
> destructors.  Am I remembering that wrong?

Hmmm... I was just considering global constructors here when I wrote this (this
constructor is constexpr). I suppose I can make it a pointer to avoid the
destructor part too.

[commit-bot: I haz the power, 2016-08-04 19:48:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-04 19:49:35]

Description was changed from

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2211143002
==========

to

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
==========

[mtklein, 2016-08-04 19:49:50]

lgtm

[bungeman-skia, 2016-08-04 20:05:07]

The CQ bit was unchecked by bungeman@google.com

[bungeman-skia, 2016-08-04 20:05:16]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-08-04 20:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 20:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 20:07:05]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[bungeman-skia, 2016-08-04 20:07:38]

bungeman@google.com changed reviewers:
+ djsollen@google.com

[bungeman-skia, 2016-08-04 20:07:38]

This does modify some public API from SkData* to sk_sp<SkData>, but it doesn't
appear this is popular API, since it doesn't appear anyone is actively using it
outside Skia.

[djsollen, 2016-08-05 11:09:46]

lgtm

[bungeman-skia, 2016-08-05 13:50:31]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-08-05 13:50:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 13:51:52]

Description was changed from

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.
==========

to

==========
Move to SkDataTable::MakeXXX and sk_sp.

Change SkDataTable::NewXXX to SkDataTable::MakeXXX and return sk_sp.
This updates users of SkDataTable to sk_sp as well.
There do not appear to be any external users of these methods.

Committed:
https://skia.googlesource.com/skia/+/feb3c1a57faee39dc10ac904f6b215ba50e286b4
==========

[commit-bot: I haz the power, 2016-08-05 13:51:53]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/feb3c1a57faee39dc10ac904f6b215ba50e286b4