include/ports/SkRemotableFontMgr.h - Issue 2211143002: Move to SkDataTable::MakeXXX and sk_sp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/ports/SkRemotableFontMgr.h

Issue 2211143002: Move to SkDataTable::MakeXXX and sk_sp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Use bare pointer for global. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/ports/SkRemotableFontMgr.h

diff --git a/include/ports/SkRemotableFontMgr.h b/include/ports/SkRemotableFontMgr.h

index ddc8e50a12e2e831b5e62c36e88f98d3a829e179..2e028cee2620f154040636a608707a6ef867ba22 100644

--- a/include/ports/SkRemotableFontMgr.h

+++ b/include/ports/SkRemotableFontMgr.h

@@ -61,10 +61,8 @@ public:

* The indexes may be used with getIndex(int) and

* matchIndexStyle(int, SkFontStyle).

- *

- * The caller must unref() the returned object.

- virtual SkDataTable* getFamilyNames() const = 0;

+ virtual sk_sp<SkDataTable> getFamilyNames() const = 0;

/**

* Returns all of the fonts with the given familyIndex.

« no previous file with comments | « include/ports/SkFontMgr_indirect.h ('k') | src/core/SkDataTable.cpp » ('j') | no next file with comments »