src/ports/SkFontMgr_FontConfigInterface.cpp - Issue 2211143002: Move to SkDataTable::MakeXXX and sk_sp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontMgr_FontConfigInterface.cpp

Issue 2211143002: Move to SkDataTable::MakeXXX and sk_sp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Use bare pointer for global. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontMgr_FontConfigInterface.cpp

diff --git a/src/ports/SkFontMgr_FontConfigInterface.cpp b/src/ports/SkFontMgr_FontConfigInterface.cpp

index 09b4d13dd4241229959299dcb81c47205e030c1c..133b503444060141b673a509a7198644a8dc5300 100644

--- a/src/ports/SkFontMgr_FontConfigInterface.cpp

+++ b/src/ports/SkFontMgr_FontConfigInterface.cpp

@@ -139,7 +139,7 @@ static bool find_by_FontIdentity(SkTypeface* cachedTypeface, void* ctx) {

class SkFontMgr_FCI : public SkFontMgr {

SkAutoTUnref<SkFontConfigInterface> fFCI;

- SkAutoTUnref<SkDataTable> fFamilyNames;

+ sk_sp<SkDataTable> fFamilyNames;

SkTypeface_FreeType::Scanner fScanner;

mutable SkMutex fMutex;

« no previous file with comments | « src/ports/SkFontConfigInterface_direct.cpp ('k') | src/ports/SkFontMgr_fontconfig.cpp » ('j') | no next file with comments »