src/fonts/SkFontMgr_indirect.cpp - Issue 2211143002: Move to SkDataTable::MakeXXX and sk_sp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/fonts/SkFontMgr_indirect.cpp

Issue 2211143002: Move to SkDataTable::MakeXXX and sk_sp. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Use bare pointer for global. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/fonts/SkFontMgr_indirect.cpp

diff --git a/src/fonts/SkFontMgr_indirect.cpp b/src/fonts/SkFontMgr_indirect.cpp

index 01a24c5174a2e46479c78a9e9dfe591e1901f75f..070c0aa40287de9e1d43a7faae9768b4aa517c7f 100644

--- a/src/fonts/SkFontMgr_indirect.cpp

+++ b/src/fonts/SkFontMgr_indirect.cpp

@@ -61,7 +61,7 @@ private:

};

void SkFontMgr_Indirect::set_up_family_names(const SkFontMgr_Indirect* self) {

- self->fFamilyNames.reset(self->fProxy->getFamilyNames());

+ self->fFamilyNames = self->fProxy->getFamilyNames();

}

int SkFontMgr_Indirect::onCountFamilies() const {

« no previous file with comments | « src/core/SkDataTable.cpp ('k') | src/ports/SkFontConfigInterface_direct.h » ('j') | no next file with comments »