Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2210253002: Limit document.createEvent to existing events (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit document.createEvent to existing events Since https://codereview.chromium.org/1673243002 a number of event interfaces have been added that are also supported in createEvent: InputEvent: https://codereview.chromium.org/1682683002 ForeignFetchEvent: https://codereview.chromium.org/1845463002 PaymentRequestUpdateEvent: https://codereview.chromium.org/1931233002 SensorErrorEvent+SensorReadingEvent: https://codereview.chromium.org/1942663003 It doesn't make sense to continue expanding document.createEvent for event interfaces which have no init*Event() methods, so limit support to the existing set and hope to converge with spec and others over time. This does not change the generated Event.cpp or EventModules.cpp. BUG=569690 Committed: https://crrev.com/62d73936675d1e11d91dd6174a37856584345b47 Cr-Commit-Position: refs/heads/master@{#409788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -7 lines) Patch
M third_party/WebKit/Source/build/scripts/make_event_factory.py View 3 chunks +81 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
foolip
PTAL
4 years, 4 months ago (2016-08-04 09:58:59 UTC) #5
foolip
See also https://codereview.chromium.org/2216593002
4 years, 4 months ago (2016-08-04 10:23:27 UTC) #6
Mike West
LGTM. Did you consider sending an FYI to blink-dev@? (Or did you already?)
4 years, 4 months ago (2016-08-04 15:15:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2210253002/1
4 years, 4 months ago (2016-08-04 15:19:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 15:23:08 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62d73936675d1e11d91dd6174a37856584345b47 Cr-Commit-Position: refs/heads/master@{#409788}
4 years, 4 months ago (2016-08-04 15:24:48 UTC) #16
foolip
4 years, 4 months ago (2016-08-04 15:35:39 UTC) #17
Message was sent while issue was closed.
On 2016/08/04 15:15:21, Mike West wrote:
> LGTM.
> 
> Did you consider sending an FYI to blink-dev@? (Or did you already?)

Good idea!
https://groups.google.com/a/chromium.org/d/msg/blink-dev/bj1SUohzcR4/5SXyG3kb...

Powered by Google App Engine
This is Rietveld 408576698