[InputEvent] Add InputEvent with basic interface behind a flag

Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330
Committed: https://crrev.com/b04e5592a3facc2e2453b9f9755060f78643884e
Cr-Commit-Position: refs/heads/master@{#376753}

[chongz, 2016-02-09 15:35:58]

chongz@chromium.org changed reviewers:
+ dtapuska@chromium.org

[chongz, 2016-02-09 15:35:59]

Can I have a review on this CL please? Thanks!

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.cpp:2083:
dispatchScopedEvent(InputEvent::create(EventTypeNames::input, eventInitDict));
Do we prefer dictionary constructor or classic one?

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.idl (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.idl:11: // TODO(chongz): Add
'inputType', 'data', 'isComposing' and 'targetRanges'
Firefox has 'isComposing'
(https://developer.mozilla.org/en-US/docs/Web/Events/input)
So I guess we can expose it first?

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:98: InputEvent
status=experimental
Do we want experimental?

[dtapuska, 2016-02-09 15:49:12]

Can you add a more descriptive commit message?

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/events/inputevents/input-event-listener-class-name.html
(right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/events/inputevents/input-event-listener-class-name.html:13:
var txt = document.getElementById("txt");
Can this be written as a webplatform test instead of a typical layout test?

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Node.cpp:2083:
dispatchScopedEvent(InputEvent::create(EventTypeNames::input, eventInitDict));
On 2016/02/09 15:35:59, chongz wrote:
> Do we prefer dictionary constructor or classic one?

this is fine I think; less code is often better. I think exposing another ctor
would be more code. We've done this approach with PointerEvents I think.

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.h (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.h:27: const String& inputType()
const { return m_inputType; }
I think this isn't necessary

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.h:39: String m_inputType;
Where is the variable assigned?

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.idl (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.idl:11: // TODO(chongz): Add
'inputType', 'data', 'isComposing' and 'targetRanges'
On 2016/02/09 15:35:59, chongz wrote:
> Firefox has 'isComposing'
> (https://developer.mozilla.org/en-US/docs/Web/Events/input)
> So I guess we can expose it first?

sgtm

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/1682683002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in:98: InputEvent
status=experimental
On 2016/02/09 15:35:59, chongz wrote:
> Do we want experimental?

This isn't actually used because you haven't exposed any flags at all. I
wouldn't put it in this test.

[chongz, 2016-02-11 22:15:04]

Description was changed from

==========
Add InputEvent with basic interface

Node::dispatchInputEvent should dispatch InputEvent instead of Event.

BUG=585330
==========

to

==========
Add InputEvent with basic interface

Just an empty class derived from UIEvent with a constructor.

Also modified the input events sent for input elements as well as the input
events dispatched for content editable.

BUG=585330
==========

[chongz, 2016-02-19 17:43:45]

Description was changed from

==========
Add InputEvent with basic interface

Just an empty class derived from UIEvent with a constructor.

Also modified the input events sent for input elements as well as the input
events dispatched for content editable.

BUG=585330
==========

to

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330
==========

[chongz, 2016-02-19 17:45:56]

Hi dtapuska, I've moved InputEvent behind a experimental runtime flag.
PTAL, thanks!

[dtapuska, 2016-02-22 15:05:02]

On 2016/02/19 17:45:56, chongz wrote:
> Hi dtapuska, I've moved InputEvent behind a experimental runtime flag.
> PTAL, thanks!

lgtm

[chongz, 2016-02-22 15:07:21]

chongz@chromium.org changed reviewers:
+ rbyers@chromium.org

[chongz, 2016-02-22 15:07:21]

Hi rbyers, can you take a look at this CL please? Thanks!

[Rick Byers, 2016-02-22 15:24:56]

LGTM

[chongz, 2016-02-22 15:25:24]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-02-22 15:26:04]

The CQ bit was unchecked by chongz@chromium.org

[chongz, 2016-02-22 15:45:21]

The CQ bit was checked by chongz@chromium.org

[chongz, 2016-02-22 15:45:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1682683002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-02-22 15:46:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1682683002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1682683002/100001

[commit-bot: I haz the power, 2016-02-22 17:50:25]

Description was changed from

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330
==========

to

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330
==========

[commit-bot: I haz the power, 2016-02-22 17:50:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-22 17:51:22]

Description was changed from

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330
==========

to

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330

Committed: https://crrev.com/b04e5592a3facc2e2453b9f9755060f78643884e
Cr-Commit-Position: refs/heads/master@{#376753}
==========

[commit-bot: I haz the power, 2016-02-22 17:51:23]

Patchset 6 (id:??) landed as
https://crrev.com/b04e5592a3facc2e2453b9f9755060f78643884e
Cr-Commit-Position: refs/heads/master@{#376753}

[chongz, 2016-08-31 21:33:49]

Description was changed from

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330

Committed: https://crrev.com/b04e5592a3facc2e2453b9f9755060f78643884e
Cr-Commit-Position: refs/heads/master@{#376753}
==========

to

==========
Add InputEvent with basic interface behind a flag

Just an empty class derived from UIEvent with a constructor.

Also modified the type of dispatched input events if InputEvent was enabled.

BUG=585330

Committed: https://crrev.com/b04e5592a3facc2e2453b9f9755060f78643884e
Cr-Commit-Position: refs/heads/master@{#376753}
==========