Start implementing ForeignFetchEvent for foreign fetch events.

Start implementing ForeignFetchEvent for foreign fetch events.

This implements most of the  new ForeignFetchEvent interface added in
https://github.com/slightlyoff/ServiceWorker/commit/d2fdb147c9c769ac6338117c1acd9f4010365f19

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=540509
Committed: https://crrev.com/3161394749bb5e100a58ac77aaafb7b9c240fcc3
Cr-Commit-Position: refs/heads/master@{#385917}

[Marijn Kruisselbrink, 2016-03-30 19:23:41]

Description was changed from

==========
WIP Start implementing ForeignFetchEvent

BUG=
==========

to

==========
WIP Start implementing ForeignFetchEvent

This implements parts of the  new ForeignFetchEventInterface added in 
https://github.com/slightlyoff/ServiceWorker/commit/6b4f712ef2aa14ec3ed953696...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=
==========

[Marijn Kruisselbrink, 2016-03-30 19:33:45]

Description was changed from

==========
WIP Start implementing ForeignFetchEvent

This implements parts of the  new ForeignFetchEventInterface added in 
https://github.com/slightlyoff/ServiceWorker/commit/6b4f712ef2aa14ec3ed953696...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=
==========

to

==========
Start implementing ForeignFetchEvent for foreign fetch events.

This implements most of the  new ForeignFetchEvent interface added in 
https://github.com/slightlyoff/ServiceWorker/commit/6b4f712ef2aa14ec3ed953696...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=540509
==========

[Marijn Kruisselbrink, 2016-04-04 18:22:15]

Description was changed from

==========
Start implementing ForeignFetchEvent for foreign fetch events.

This implements most of the  new ForeignFetchEvent interface added in 
https://github.com/slightlyoff/ServiceWorker/commit/6b4f712ef2aa14ec3ed953696...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=540509
==========

to

==========
Start implementing ForeignFetchEvent for foreign fetch events.

This implements most of the  new ForeignFetchEvent interface added in 
https://github.com/slightlyoff/ServiceWorker/commit/d2fdb147c9c769ac6338117c1...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=540509
==========

[Marijn Kruisselbrink, 2016-04-04 18:23:00]

mek@chromium.org changed reviewers:
+ falken@chromium.org

[falken, 2016-04-05 07:03:09]

lgtm

[Marijn Kruisselbrink, 2016-04-05 17:25:41]

mek@chromium.org changed reviewers:
+ japhet@chromium.org, mpearson@chromium.org

[Marijn Kruisselbrink, 2016-04-05 17:25:41]

+japhet for core/ and web/ OWNERS
+mpearson for histograms OWNERS

[Mark P, 2016-04-05 18:18:09]

On 2016/04/05 17:25:41, Marijn Kruisselbrink wrote:
> +japhet for core/ and web/ OWNERS
> +mpearson for histograms OWNERS

histograms.xml lgtm, though note you will have to resolve / rebase the
UseCounter numbers because you're not synced to head
(e.g., https://codereview.chromium.org/1835463002/ was just submitted that used
the numbers you want)

--mark

[Marijn Kruisselbrink, 2016-04-07 19:08:07]

japhet: ping

[Nate Chapin, 2016-04-07 20:51:04]

lgtm

https://codereview.chromium.org/1845463002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (left):

https://codereview.chromium.org/1845463002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:296: void
ServiceWorkerGlobalScopeProxy::dispatchFetchEventImpl(int eventID, const
WebServiceWorkerRequest& webRequest, const AtomicString& eventTypeName)
I would be inclined to keep the common logic in a helper, but I guess it's
debatable whether there's enough common logic remaining to justify the helper?

[Marijn Kruisselbrink, 2016-04-07 21:00:06]

https://codereview.chromium.org/1845463002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp (left):

https://codereview.chromium.org/1845463002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp:296: void
ServiceWorkerGlobalScopeProxy::dispatchFetchEventImpl(int eventID, const
WebServiceWorkerRequest& webRequest, const AtomicString& eventTypeName)
On 2016/04/07 at 20:51:04, Nate Chapin wrote:
> I would be inclined to keep the common logic in a helper, but I guess it's
debatable whether there's enough common logic remaining to justify the helper?

Yeah, pretty much the last three lines are the only common logic, and even then
with different types, so needing templates like this:

template <typename EventType, typename EventInitType>
void ServiceWorkerGlobalScopeProxy::dispatchFetchEventImpl(RespondWithObserver*
observer, const EventInitType& eventInit, const AtomicString& eventTypeName) {
  EventType* event = EventType::create(eventTypeName, eventInit, observer);
  DispatchEventResult dispatchResult =
workerGlobalScope()->dispatchEvent(event);
  observer->didDipatchEvent(dispatchResult);
}

Which doesn't really seem worth it (alternatively without templates just the
last two lines could be common logic).

[Marijn Kruisselbrink, 2016-04-07 21:00:09]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-04-07 21:00:09]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/1845463002/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-07 21:02:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463002/100001

[commit-bot: I haz the power, 2016-04-07 21:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 21:09:03]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Marijn Kruisselbrink, 2016-04-07 21:23:32]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2016-04-07 21:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
japhet@chromium.org, mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/1845463002/#ps120001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-07 21:24:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463002/120001

[commit-bot: I haz the power, 2016-04-07 22:36:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 22:36:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marijn Kruisselbrink, 2016-04-07 22:37:27]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2016-04-07 22:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1845463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1845463002/120001

[commit-bot: I haz the power, 2016-04-07 23:13:31]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-07 23:15:48]

Description was changed from

==========
Start implementing ForeignFetchEvent for foreign fetch events.

This implements most of the  new ForeignFetchEvent interface added in 
https://github.com/slightlyoff/ServiceWorker/commit/d2fdb147c9c769ac6338117c1...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=540509
==========

to

==========
Start implementing ForeignFetchEvent for foreign fetch events.

This implements most of the  new ForeignFetchEvent interface added in
https://github.com/slightlyoff/ServiceWorker/commit/d2fdb147c9c769ac6338117c1...

For now all this does is unwrap the Response from a ForeignFetchResponse
dictionary. In follow-up patches support for the other properties of a
ForeignFetchResponse will be added.

BUG=540509

Committed: https://crrev.com/3161394749bb5e100a58ac77aaafb7b9c240fcc3
Cr-Commit-Position: refs/heads/master@{#385917}
==========

[commit-bot: I haz the power, 2016-04-07 23:15:49]

Patchset 7 (id:??) landed as
https://crrev.com/3161394749bb5e100a58ac77aaafb7b9c240fcc3
Cr-Commit-Position: refs/heads/master@{#385917}