Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2216593002: Drop document.createEvent support for things still behind a flag (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@createEvent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop document.createEvent support for things still behind a flag The list of interfaces to remove was found by looking for things in the generated Event.cpp and EventModules.cpp that are behind a RuntimeEnabledFeatures::*Enabled() check, where the feature in question is status=experimental or status=test in RuntimeEnabledFeatures.in. Happily, this removes the five new cases mentioned in https://codereview.chromium.org/2210253002/ as well as five older ones. BUG=569690 Committed: https://crrev.com/b2343c3b045d6ac978a4e9b003a28c9c9aec2b76 Cr-Commit-Position: refs/heads/master@{#409926}

Patch Set 1 #

Patch Set 2 : rm no-argument create() and ctors #

Patch Set 3 : fix LayoutTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -176 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/DeviceLight/create-event.html View 1 2 3 chunks +2 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/DeviceLight/create-event-expected.txt View 1 2 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/relatedevent.html View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/relatedevent-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/dom/nodes/Document-createEvent-expected.txt View 1 2 5 chunks +5 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/make_event_factory.py View 4 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/events/AnimationPlayerEvent.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/AnimationPlayerEvent.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/PointerEvent.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/events/RelatedEvent.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/RelatedEvent.cpp View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 8 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/device_light/DeviceLightEvent.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/device_light/DeviceLightEvent.cpp View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEvent.cpp View 1 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequestUpdateEventTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorErrorEvent.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorErrorEvent.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorReadingEvent.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/SensorReadingEvent.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEvent.cpp View 1 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp View 1 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
foolip
PTAL, depends on https://codereview.chromium.org/2210253002/
4 years, 4 months ago (2016-08-04 10:24:05 UTC) #2
Mike West
LGTM. Pulling these before they ship seems a) safe, and b) like a good idea.
4 years, 4 months ago (2016-08-04 15:16:06 UTC) #4
foolip
After writing https://groups.google.com/a/chromium.org/d/msg/blink-dev/bj1SUohzcR4/5SXyG3kbBAAJ I realized I could remove some empty create() methods and constructors. In ...
4 years, 4 months ago (2016-08-04 15:56:29 UTC) #8
please use gerrit instead
payments lgtm
4 years, 4 months ago (2016-08-04 16:27:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216593002/20001
4 years, 4 months ago (2016-08-04 16:54:09 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/267566)
4 years, 4 months ago (2016-08-04 17:37:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216593002/40001
4 years, 4 months ago (2016-08-04 20:58:38 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-04 23:02:37 UTC) #20
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 23:06:16 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b2343c3b045d6ac978a4e9b003a28c9c9aec2b76
Cr-Commit-Position: refs/heads/master@{#409926}

Powered by Google App Engine
This is Rietveld 408576698