Don't report removed sources as changed in CacheConsistencyValidatorImpl.

Don't report removed sources as changed in CacheConsistencyValidatorImpl.


Also I believe we don't need this check anymore.
context.getLibrariesContaining(source).isEmpty &&
context.getLibrariesDependingOn(source).isEmpty)

1. It was not used in applyChanges(), which could probably cause losing
some dependencies.

2. Since https://codereview.chromium.org/2172143003 we record that
there are dependencies on the removed, so not existing, source. So,
when the source is added again, _sourceAvailable() will invalidate
its CONTENT and the whole transitive closure of its users.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6cceb72ea753cdd190c9e87449a1a1ad8fe32262

[Brian Wilkerson, 2016-08-03 20:24:28]

lgtm

[scheglov, 2016-08-03 20:30:14]

Description was changed from

==========
Don't report removed sources as changed in CacheConsistencyValidatorImpl.


Also I believe we don't need this check anymore.
context.getLibrariesContaining(source).isEmpty &&
context.getLibrariesDependingOn(source).isEmpty)

1. It was not used in applyChanges(), which could probably cause losing
some dependencies.

2. Since https://codereview.chromium.org/2172143003 we record that
there are dependencies on the removed, so not existing, source. So,
when the source is added again, _sourceAvailable() will invalidate
its CONTENT and the whole transitive closure of its users.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Don't report removed sources as changed in CacheConsistencyValidatorImpl.


Also I believe we don't need this check anymore.
context.getLibrariesContaining(source).isEmpty &&
context.getLibrariesDependingOn(source).isEmpty)

1. It was not used in applyChanges(), which could probably cause losing
some dependencies.

2. Since https://codereview.chromium.org/2172143003 we record that
there are dependencies on the removed, so not existing, source. So,
when the source is added again, _sourceAvailable() will invalidate
its CONTENT and the whole transitive closure of its users.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6cceb72ea753cdd190c9e87449a1a1ad8fe32262
==========

[scheglov, 2016-08-03 20:30:15]

Committed patchset #1 (id:1) manually as
6cceb72ea753cdd190c9e87449a1a1ad8fe32262 (presubmit successful).