Issue 2172143003: Fix for recording dependency when the user is recorder before the provider.

Issue 2172143003: Fix for recording dependency when the user is recorder before the provider. (Closed)

Created:
4 years, 5 months ago by scheglov

Modified:
4 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for recording dependency when the user is recorder before the provider. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/091b605e8957a9e1135428f1e41763a1cabf85ff

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/context/cache.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	pkg/analyzer/test/src/context/cache_test.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

On 2016/07/22 07:15:47, scheglov wrote: This seems odd to me. It seems like the case ...

4 years, 5 months ago (2016-07-22 17:20:13 UTC) #2

scheglov

On 2016/07/22 17:20:13, Paul Berry wrote: > On 2016/07/22 07:15:47, scheglov wrote: > > This ...

4 years, 5 months ago (2016-07-22 17:33:26 UTC) #3

On 2016/07/22 17:20:13, Paul Berry wrote:
> On 2016/07/22 07:15:47, scheglov wrote:
> 
> This seems odd to me.  It seems like the case you are trying to fix is where
> result2 depends on result1, yet at the time result2 is recorded, we have not
yet
> computed a value for result1.  How could that occur in normal operation?

Circular dependency.

a.dart
---
export 'b.dart';
class A {}

b.dart
---
export 'a.dart';
class B {}

Analysis of these two files fails to establish following dependencies:

LIBRARY_ELEMENT5 for /lib/math/math.dart failed to depend on LIBRARY_ELEMENT5
for /lib/core/core.dart
LIBRARY_ELEMENT5 for /lib/math/math.dart failed to depend on LIBRARY_ELEMENT5
for /lib/core/core.dart
LIBRARY_ELEMENT5 for /lib/async/async.dart failed to depend on LIBRARY_ELEMENT5
for /lib/core/core.dart
LIBRARY_ELEMENT5 for /lib/async/async.dart failed to depend on LIBRARY_ELEMENT5
for /lib/core/core.dart
LIBRARY_ELEMENT5 for /b.dart failed to depend on LIBRARY_ELEMENT5 for /a.dart
READY_LIBRARY_ELEMENT6 for /lib/math/math.dart failed to depend on
READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
READY_LIBRARY_ELEMENT6 for /lib/math/math.dart failed to depend on
READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
READY_LIBRARY_ELEMENT6 for /lib/async/async.dart failed to depend on
READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
READY_LIBRARY_ELEMENT6 for /lib/async/async.dart failed to depend on
READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
READY_LIBRARY_ELEMENT6 for /b.dart failed to depend on READY_LIBRARY_ELEMENT6
for /a.dart
READY_LIBRARY_ELEMENT2 for /lib/math/math.dart failed to depend on
READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
READY_LIBRARY_ELEMENT2 for /lib/math/math.dart failed to depend on
READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
READY_LIBRARY_ELEMENT2 for /lib/async/async.dart failed to depend on
READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
READY_LIBRARY_ELEMENT2 for /lib/async/async.dart failed to depend on
READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
READY_LIBRARY_ELEMENT2 for /b.dart failed to depend on READY_LIBRARY_ELEMENT2
for /a.dart
READY_LIBRARY_ELEMENT7 for /lib/math/math.dart failed to depend on
READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
READY_LIBRARY_ELEMENT7 for /lib/math/math.dart failed to depend on
READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
READY_LIBRARY_ELEMENT7 for /lib/async/async.dart failed to depend on
READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
READY_LIBRARY_ELEMENT7 for /lib/async/async.dart failed to depend on
READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
READY_LIBRARY_ELEMENT7 for /b.dart failed to depend on READY_LIBRARY_ELEMENT7
for /a.dart

Paul Berry

On 2016/07/22 17:33:26, scheglov wrote: > On 2016/07/22 17:20:13, Paul Berry wrote: > > On ...

4 years, 5 months ago (2016-07-22 17:40:39 UTC) #4

On 2016/07/22 17:33:26, scheglov wrote:
> On 2016/07/22 17:20:13, Paul Berry wrote:
> > On 2016/07/22 07:15:47, scheglov wrote:
> > 
> > This seems odd to me.  It seems like the case you are trying to fix is where
> > result2 depends on result1, yet at the time result2 is recorded, we have not
> yet
> > computed a value for result1.  How could that occur in normal operation?
> 
> Circular dependency.
> 
> a.dart
> ---
> export 'b.dart';
> class A {}
> 
> b.dart
> ---
> export 'a.dart';
> class B {}
> 
> Analysis of these two files fails to establish following dependencies:
> 
> LIBRARY_ELEMENT5 for /lib/math/math.dart failed to depend on LIBRARY_ELEMENT5
> for /lib/core/core.dart
> LIBRARY_ELEMENT5 for /lib/math/math.dart failed to depend on LIBRARY_ELEMENT5
> for /lib/core/core.dart
> LIBRARY_ELEMENT5 for /lib/async/async.dart failed to depend on
LIBRARY_ELEMENT5
> for /lib/core/core.dart
> LIBRARY_ELEMENT5 for /lib/async/async.dart failed to depend on
LIBRARY_ELEMENT5
> for /lib/core/core.dart
> LIBRARY_ELEMENT5 for /b.dart failed to depend on LIBRARY_ELEMENT5 for /a.dart
> READY_LIBRARY_ELEMENT6 for /lib/math/math.dart failed to depend on
> READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT6 for /lib/math/math.dart failed to depend on
> READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT6 for /lib/async/async.dart failed to depend on
> READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT6 for /lib/async/async.dart failed to depend on
> READY_LIBRARY_ELEMENT6 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT6 for /b.dart failed to depend on READY_LIBRARY_ELEMENT6
> for /a.dart
> READY_LIBRARY_ELEMENT2 for /lib/math/math.dart failed to depend on
> READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT2 for /lib/math/math.dart failed to depend on
> READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT2 for /lib/async/async.dart failed to depend on
> READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT2 for /lib/async/async.dart failed to depend on
> READY_LIBRARY_ELEMENT2 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT2 for /b.dart failed to depend on READY_LIBRARY_ELEMENT2
> for /a.dart
> READY_LIBRARY_ELEMENT7 for /lib/math/math.dart failed to depend on
> READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT7 for /lib/math/math.dart failed to depend on
> READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT7 for /lib/async/async.dart failed to depend on
> READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT7 for /lib/async/async.dart failed to depend on
> READY_LIBRARY_ELEMENT7 for /lib/core/core.dart
> READY_LIBRARY_ELEMENT7 for /b.dart failed to depend on READY_LIBRARY_ELEMENT7
> for /a.dart

Got it, ok.  LGTM.

scheglov

Committed patchset #1 (id:1) manually as 091b605e8957a9e1135428f1e41763a1cabf85ff (presubmit successful).

4 years, 5 months ago (2016-07-23 16:40:51 UTC) #6

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages