Don't report removed sources as changed in CacheConsistencyValidatorImpl.

pkg/analyzer/lib/src/context/context.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.context.context;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
@@ skipping 2050 matching lines @@
 
   CacheConsistencyValidatorImpl(this.context);
 
   @override
   List<Source> getSourcesToComputeModificationTimes() {
     return context._privatePartition.sources.toList();
   }
 
   @override
   bool sourceModificationTimesComputed(List<Source> sources, List<int> times) {
-    int consistencyCheckStart = JavaSystem.nanoTime();
+    Stopwatch timer = new Stopwatch()..start();
     HashSet<Source> changedSources = new HashSet<Source>();
-    HashSet<Source> missingSources = new HashSet<Source>();
+    HashSet<Source> removedSources = new HashSet<Source>();
     for (int i = 0; i < sources.length; i++) {
       Source source = sources[i];
       // When a source is in the content cache,
       // its modification time in the file system does not matter.
       if (context._contentCache.getModificationStamp(source) != null) {
         continue;
       }
       // When we were not able to compute the modification time in the
       // file system, there is nothing to compare with, so skip the source.
       int sourceTime = times[i];
       if (sourceTime == null) {
         continue;
       }
       // Compare with the modification time in the cache entry.
       CacheEntry entry = context._privatePartition.get(source);
       if (entry != null) {
-        if (sourceTime != entry.modificationTime) {
-          changedSources.add(source);
-          PerformanceStatistics
-              .cacheConsistencyValidationStatistics.numOfModified++;
-        }
-        if (entry.exception != null) {
+        if (entry.modificationTime != sourceTime) {
           if (sourceTime == -1) {
-            missingSources.add(source);
+            removedSources.add(source);
             PerformanceStatistics
-                .cacheConsistencyValidationStatistics.numOfModified++;
+                .cacheConsistencyValidationStatistics.numOfRemoved++;
+          } else {
+            changedSources.add(source);
+            PerformanceStatistics
+                .cacheConsistencyValidationStatistics.numOfChanged++;
           }
         }
       }
     }
     for (Source source in changedSources) {
       context._sourceChanged(source);
     }
-    int removalCount = 0;
-    for (Source source in missingSources) {
-      if (context.getLibrariesContaining(source).isEmpty &&
-          context.getLibrariesDependingOn(source).isEmpty) {
-        context._removeFromCache(source);
-        removalCount++;
-      }
+    for (Source source in removedSources) {
+      context._sourceRemoved(source);
     }
-    int consistencyCheckEnd = JavaSystem.nanoTime();
-    if (changedSources.length > 0 || missingSources.length > 0) {
+    if (changedSources.length > 0 || removedSources.length > 0) {
       StringBuffer buffer = new StringBuffer();
       buffer.write("Consistency check took ");
-      buffer.write((consistencyCheckEnd - consistencyCheckStart) / 1000000.0);
+      buffer.write(timer.elapsedMilliseconds);
       buffer.writeln(" ms and found");
       buffer.write("  ");
       buffer.write(changedSources.length);
-      buffer.writeln(" inconsistent entries");
+      buffer.writeln(" changed sources");
       buffer.write("  ");
-      buffer.write(missingSources.length);
-      buffer.write(" missing sources (");
-      buffer.write(removalCount);
-      buffer.writeln(" removed");
-      for (Source source in missingSources) {
-        buffer.write("    ");
-        buffer.writeln(source.fullName);
-      }
+      buffer.write(removedSources.length);
+      buffer.write(" removed sources.");
       context._logInformation(buffer.toString());
     }
-    return changedSources.length > 0;
+    return changedSources.isNotEmpty || removedSources.isNotEmpty;
   }
 }
 
 /**
  * An object that manages the partitions that can be shared between analysis
  * contexts.
  */
 class PartitionManager {
   /**
    * A table mapping SDK's to the partitions used for those SDK's.
@@ skipping 155 matching lines @@
     }
     DartSdk sdk = factory.dartSdk;
     if (sdk == null) {
       throw new IllegalArgumentException(
           "The source factory for an SDK analysis context must have a DartUriResolver");
     }
     return new AnalysisCache(
         <CachePartition>[AnalysisEngine.instance.partitionManager.forSdk(sdk)]);
   }
 }