Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 2209493003: Don't report removed sources as changed in CacheConsistencyValidatorImpl. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/engine.dart
diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart
index 394a662fecc424ecf53e1c185834b7a7f232bea6..967095a22447dd9ce6f8d4abf180cb2375fc59c3 100644
--- a/pkg/analyzer/lib/src/generated/engine.dart
+++ b/pkg/analyzer/lib/src/generated/engine.dart
@@ -1191,6 +1191,11 @@ class AnalysisOptionsImpl implements AnalysisOptions {
static const int ENABLE_SUPER_MIXINS_FLAG = 0x40;
/**
+ * The default list of non-nullable type names.
+ */
+ static const List<String> NONNULLABLE_TYPES = const <String>[];
+
+ /**
* A predicate indicating whether analysis is to parse and analyze function
* bodies.
*/
@@ -1334,11 +1339,6 @@ class AnalysisOptionsImpl implements AnalysisOptions {
bool implicitDynamic = true;
/**
- * The default list of non-nullable type names.
- */
- static const List<String> NONNULLABLE_TYPES = const <String>[];
-
- /**
* Initialize a newly created set of analysis options to have their default
* values.
*/
@@ -1560,18 +1560,26 @@ class ApplyChangesStatus {
*/
class CacheConsistencyValidationStatistics {
/**
- * Number of sources which were modified, but the context was not notified
+ * Number of sources which were changed, but the context was not notified
* about it, so this fact was detected only during cache consistency
* validation.
*/
- int numOfModified = 0;
+ int numOfChanged = 0;
/**
- * Number of sources which were deleted, but the context was not notified
+ * Number of sources which stopped existing, but the context was not notified
* about it, so this fact was detected only during cache consistency
* validation.
*/
- int numOfDeleted = 0;
+ int numOfRemoved = 0;
+
+ /**
+ * Reset all counters.
+ */
+ void reset() {
+ numOfChanged = 0;
+ numOfRemoved = 0;
+ }
}
/**
« no previous file with comments | « pkg/analyzer/lib/src/context/context.dart ('k') | pkg/analyzer/test/src/context/context_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698