Simplify reload error reporting

Simplify reload error reporting

- [x] Rationalize the load failure code path.
- [x] Remove support for reload to be aborted via a callback.
- [x] If a reload fails due to an unwind error, ignore it as the isolate is dead anyway.
- [x] Move more allocations into the zone.

Committed: https://github.com/dart-lang/sdk/commit/a6114c23cd6219fcface6c848cc8379ff0928c00

[Cutch, 2016-08-02 22:57:48]

Description was changed from

==========
Simplify reload error reporting

BUG=
==========

to

==========
Simplify reload error reporting

- [x] Rationalize the load failure code path.
- [x] Remove support for reload to be aborted via a callback.
- [x] If a reload fails due to an unwind error, ignore it as the isolate is dead
anyway.
- [x] Move more allocations into the zone.
==========

[Cutch, 2016-08-02 22:57:48]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-08-02 23:11:15]

Fixes hot reload bots.

TBR=rmacnak

[Cutch, 2016-08-02 23:11:35]

Description was changed from

==========
Simplify reload error reporting

- [x] Rationalize the load failure code path.
- [x] Remove support for reload to be aborted via a callback.
- [x] If a reload fails due to an unwind error, ignore it as the isolate is dead
anyway.
- [x] Move more allocations into the zone.
==========

to

==========
Simplify reload error reporting

- [x] Rationalize the load failure code path.
- [x] Remove support for reload to be aborted via a callback.
- [x] If a reload fails due to an unwind error, ignore it as the isolate is dead
anyway.
- [x] Move more allocations into the zone.

Committed:
https://github.com/dart-lang/sdk/commit/a6114c23cd6219fcface6c848cc8379ff0928c00
==========

[Cutch, 2016-08-02 23:11:36]

Committed patchset #1 (id:1) manually as
a6114c23cd6219fcface6c848cc8379ff0928c00 (presubmit successful).

[rmacnak, 2016-08-03 19:55:25]

https://codereview.chromium.org/2208553002/diff/1/runtime/vm/unit_test.cc
File runtime/vm/unit_test.cc (right):

https://codereview.chromium.org/2208553002/diff/1/runtime/vm/unit_test.cc#new...
runtime/vm/unit_test.cc:300: fprintf(stderr, "RELOAD REPORT:\n%s\n",
js.ToCString());
OS::PrintErr

https://codereview.chromium.org/2208553002/diff/1/runtime/vm/unit_test.cc#new...
runtime/vm/unit_test.cc:306: return Dart_Null();
Shouldn't this return some kind of error?

[Cutch, 2016-08-03 21:17:19]

https://codereview.chromium.org/2208553002/diff/1/runtime/vm/unit_test.cc
File runtime/vm/unit_test.cc (right):

https://codereview.chromium.org/2208553002/diff/1/runtime/vm/unit_test.cc#new...
runtime/vm/unit_test.cc:300: fprintf(stderr, "RELOAD REPORT:\n%s\n",
js.ToCString());
On 2016/08/03 19:55:25, rmacnak wrote:
> OS::PrintErr

Acknowledged.

https://codereview.chromium.org/2208553002/diff/1/runtime/vm/unit_test.cc#new...
runtime/vm/unit_test.cc:306: return Dart_Null();
On 2016/08/03 19:55:25, rmacnak wrote:
> Shouldn't this return some kind of error?

In the unit tests we keep the reload context alive and grab the error from it
explicitly.