Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1990)

Unified Diff: runtime/vm/isolate_reload.h

Issue 2208553002: Simplify reload error reporting (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate_reload.h
diff --git a/runtime/vm/isolate_reload.h b/runtime/vm/isolate_reload.h
index d260768170c4b218953411d6a879a49cf10cdae8..c252bfdcf121ecaf43e34e83509aa5f804cf2009 100644
--- a/runtime/vm/isolate_reload.h
+++ b/runtime/vm/isolate_reload.h
@@ -197,9 +197,17 @@ class IsolateReloadContext {
return !instance_morphers_.is_empty();
}
- // NOTE: FinalizeLoading will be called *before* Reload() returns.
+ // NOTE: FinalizeLoading will be called *before* Reload() returns. This
+ // function will not be called if the embedder does not call
+ // Dart_FinalizeLoading.
void FinalizeLoading();
- void AbortReload(const Error& error);
+
+ // NOTE: FinalizeFailedLoad will be called *before* Reload returns. This
+ // function will not be called if the embedder calls Dart_FinalizeLoading.
+ void FinalizeFailedLoad(const Error& error);
+
+ // Called by both FinalizeLoading and FinalizeFailedLoad.
+ void CommonFinalizeTail();
// Report back through the observatory channels.
void ReportError(const Error& error);
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/isolate_reload.cc » ('j') | runtime/vm/unit_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698