Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: runtime/vm/isolate.cc

Issue 2208553002: Simplify reload error reporting (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 6674d94567fa46d2c1348f8afcc37f6888f4ea2a..bf3b924f10a55f4152e85e76f7e6450ae988fc9a 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -660,12 +660,6 @@ static MessageHandler::MessageStatus StoreError(Thread* thread,
MessageHandler::MessageStatus IsolateMessageHandler::ProcessUnhandledException(
const Error& result) {
- NOT_IN_PRODUCT(
- if (I->IsReloading()) {
- I->ReportReloadError(result);
- return kOK;
- }
- )
// Generate the error and stacktrace strings for the error message.
String& exc_str = String::Handle(T->zone());
String& stacktrace_str = String::Handle(T->zone());
@@ -1089,12 +1083,6 @@ bool Isolate::CanReload() const {
#ifndef PRODUCT
-void Isolate::ReportReloadError(const Error& error) {
- ASSERT(IsReloading());
- reload_context_->AbortReload(error);
-}
-
-
bool Isolate::ReloadSources(JSONStream* js,
bool force_reload,
bool dont_delete_reload_context) {
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/isolate_reload.h » ('j') | runtime/vm/unit_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698