Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: runtime/vm/isolate_reload.h

Issue 2208553002: Simplify reload error reporting (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ISOLATE_RELOAD_H_ 5 #ifndef VM_ISOLATE_RELOAD_H_
6 #define VM_ISOLATE_RELOAD_H_ 6 #define VM_ISOLATE_RELOAD_H_
7 7
8 #include "include/dart_tools_api.h" 8 #include "include/dart_tools_api.h"
9 9
10 #include "vm/hash_map.h" 10 #include "vm/hash_map.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 void ReportOnJSON(JSONStream* stream); 190 void ReportOnJSON(JSONStream* stream);
191 191
192 // Store morphing operation. 192 // Store morphing operation.
193 void AddInstanceMorpher(InstanceMorpher* morpher); 193 void AddInstanceMorpher(InstanceMorpher* morpher);
194 194
195 // Tells whether instance in the heap must be morphed. 195 // Tells whether instance in the heap must be morphed.
196 bool HasInstanceMorphers() const { 196 bool HasInstanceMorphers() const {
197 return !instance_morphers_.is_empty(); 197 return !instance_morphers_.is_empty();
198 } 198 }
199 199
200 // NOTE: FinalizeLoading will be called *before* Reload() returns. 200 // NOTE: FinalizeLoading will be called *before* Reload() returns. This
201 // function will not be called if the embedder does not call
202 // Dart_FinalizeLoading.
201 void FinalizeLoading(); 203 void FinalizeLoading();
202 void AbortReload(const Error& error); 204
205 // NOTE: FinalizeFailedLoad will be called *before* Reload returns. This
206 // function will not be called if the embedder calls Dart_FinalizeLoading.
207 void FinalizeFailedLoad(const Error& error);
208
209 // Called by both FinalizeLoading and FinalizeFailedLoad.
210 void CommonFinalizeTail();
203 211
204 // Report back through the observatory channels. 212 // Report back through the observatory channels.
205 void ReportError(const Error& error); 213 void ReportError(const Error& error);
206 void ReportSuccess(); 214 void ReportSuccess();
207 215
208 void set_saved_root_library(const Library& value); 216 void set_saved_root_library(const Library& value);
209 217
210 void set_saved_libraries(const GrowableObjectArray& value); 218 void set_saved_libraries(const GrowableObjectArray& value);
211 219
212 void VisitObjectPointers(ObjectPointerVisitor* visitor); 220 void VisitObjectPointers(ObjectPointerVisitor* visitor);
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 friend class ObjectLocator; 343 friend class ObjectLocator;
336 friend class MarkFunctionsForRecompilation; // IsDirty. 344 friend class MarkFunctionsForRecompilation; // IsDirty.
337 friend class ReasonForCancelling; 345 friend class ReasonForCancelling;
338 346
339 static Dart_FileModifiedCallback file_modified_callback_; 347 static Dart_FileModifiedCallback file_modified_callback_;
340 }; 348 };
341 349
342 } // namespace dart 350 } // namespace dart
343 351
344 #endif // VM_ISOLATE_RELOAD_H_ 352 #endif // VM_ISOLATE_RELOAD_H_
OLDNEW
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/isolate_reload.cc » ('j') | runtime/vm/unit_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698